diff mbox series

[v2,11/22] test-trace2: mark unused argv/argc parameters

Message ID	20230829234525.GI227214@coredump.intra.peff.net (mailing list archive)
State	Accepted
Commit	51bf8676c09aefaa8ccd6de0bcae4e0e532cc672
Headers	show Return-Path: <git-owner@vger.kernel.org> Date: Tue, 29 Aug 2023 19:45:25 -0400 From: Jeff King <peff@peff.net> To: git@vger.kernel.org Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>, Phillip Wood <phillip.wood@dunelm.org.uk> Subject: [PATCH v2 11/22] test-trace2: mark unused argv/argc parameters Message-ID: <20230829234525.GI227214@coredump.intra.peff.net> References: <20230829234305.GA226944@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230829234305.GA226944@coredump.intra.peff.net> Precedence: bulk
Series	Yet Another Unused Parameter Series \| expand [v2,0/22] Yet Another Unused Parameter Series [v2,01/22] sequencer: use repository parameter in short_commit_name() [v2,02/22] sequencer: mark repository argument as unused [v2,03/22] ref-filter: mark unused parameters in parser callbacks [v2,04/22] pack-bitmap: mark unused parameters in show_object callback [v2,05/22] worktree: mark unused parameters in each_ref_fn callback [v2,06/22] commit-graph: mark unused data parameters in generation callbacks [v2,07/22] ls-tree: mark unused parameter in callback [v2,08/22] stash: mark unused parameter in diff callback [v2,09/22] trace2: mark unused us_elapsed_absolute parameters [v2,10/22] trace2: mark unused config callback parameter [v2,11/22] test-trace2: mark unused argv/argc parameters [v2,12/22] grep: mark unused parameter in output function [v2,13/22] add-interactive: mark unused callback parameters [v2,14/22] negotiator/noop: mark unused callback parameters [v2,15/22] worktree: mark unused parameters in noop repair callback [v2,16/22] imap-send: mark unused parameters with NO_OPENSSL [v2,17/22] grep: mark unused parmaeters in pcre fallbacks [v2,18/22] credential: mark unused parameter in urlmatch callback [v2,19/22] fetch: mark unused parameter in ref_transaction callback [v2,20/22] bundle-uri: mark unused parameters in callbacks [v2,21/22] gc: mark unused descriptors in scheduler callbacks [v2,22/22] update-ref: mark unused parameter in parser callbacks

Commit Message

Jeff King Aug. 29, 2023, 11:45 p.m. UTC

The trace2 test helper uses function pointers to dispatch to individual
tests. Not all tests bother looking at their argv/argc parameters. We
could tighten this up (e.g., complaining when seeing unexpected
parameters), but for internal test code it's not worth worrying about.

This is similar in spirit to 126e3b3d2a (t/helper: mark unused argv/argc
arguments, 2023-03-28).

Signed-off-by: Jeff King <peff@peff.net>
---
 t/helper/test-trace2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/t/helper/test-trace2.c b/t/helper/test-trace2.c
index 20c7495f38..d5ca0046c8 100644
--- a/t/helper/test-trace2.c
+++ b/t/helper/test-trace2.c
@@ -45,7 +45,7 @@  static int get_i(int *p_value, const char *data)
  * [] "def_param" events for all of the "interesting" pre-defined
  * config settings.
  */
-static int ut_001return(int argc, const char **argv)
+static int ut_001return(int argc UNUSED, const char **argv)
 {
 	int rc;
 
@@ -65,7 +65,7 @@  static int ut_001return(int argc, const char **argv)
  * [] "def_param" events for all of the "interesting" pre-defined
  * config settings.
  */
-static int ut_002exit(int argc, const char **argv)
+static int ut_002exit(int argc UNUSED, const char **argv)
 {
 	int rc;
 
@@ -201,7 +201,7 @@  static int ut_006data(int argc, const char **argv)
 	return 0;
 }
 
-static int ut_007BUG(int argc, const char **argv)
+static int ut_007BUG(int argc UNUSED, const char **argv UNUSED)
 {
 	/*
 	 * Exercise BUG() to ensure that the message is printed to trace2.