| Message ID | 20231026182231.3369370-2-nasamuffin@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 831401bb1462945eec1f30b2f7217510694153c7 |
| Headers | show |
| Series | [v4,1/2] t0091-bugreport: stop using i18ngrep | expand |
emilyshaffer@google.com writes: > From: Emily Shaffer <nasamuffin@google.com> > > Since e6545201ad (Merge branch 'ab/detox-config-gettext', 2021-04-13), > test_i18ngrep is no longer required. Quit using it in the bugreport > tests, since it's setting a bad example for tests added later. > > Signed-off-by: Emily Shaffer <nasamuffin@google.com> > --- Makes sense. Thanks. > t/t0091-bugreport.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t0091-bugreport.sh b/t/t0091-bugreport.sh > index f6998269be..e1588f71b7 100755 > --- a/t/t0091-bugreport.sh > +++ b/t/t0091-bugreport.sh > @@ -65,7 +65,7 @@ test_expect_success '--output-directory puts the report in the provided dir' ' > > test_expect_success 'incorrect arguments abort with usage' ' > test_must_fail git bugreport --false 2>output && > - test_i18ngrep usage output && > + grep usage output && > test_path_is_missing git-bugreport-* > '
diff --git a/t/t0091-bugreport.sh b/t/t0091-bugreport.sh index f6998269be..e1588f71b7 100755 --- a/t/t0091-bugreport.sh +++ b/t/t0091-bugreport.sh @@ -65,7 +65,7 @@ test_expect_success '--output-directory puts the report in the provided dir' ' test_expect_success 'incorrect arguments abort with usage' ' test_must_fail git bugreport --false 2>output && - test_i18ngrep usage output && + grep usage output && test_path_is_missing git-bugreport-* '