| Message ID | 20240401190751.8676-1-ville.skytta@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d7805bc74351e61126e587a7470e3fbf843caf8a |
| Headers | show |
| Series | completion: protect prompt against unset SHOWUPSTREAM in nounset mode | expand |
diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 3826f52dec..5330e769a7 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -141,7 +141,7 @@ __git_ps1_show_upstream () # parse configuration values local option - for option in ${GIT_PS1_SHOWUPSTREAM}; do + for option in ${GIT_PS1_SHOWUPSTREAM-}; do case "$option" in git|svn) upstream_type="$option" ;; verbose) verbose=1 ;;
As it stands, the only call site of `__git_ps1_show_upstream` checks that the `GIT_PS1_SHOWUPSTREAM` variable is set, so this is effectively a no-op. However, that might change, and chances of noticing the unprotected use might not be that high when it does. Signed-off-by: Ville Skyttä <ville.skytta@iki.fi> --- contrib/completion/git-prompt.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)