| Message ID | 20240429082320.GD233423@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tightening ref handling outside of refs/ | expand |
diff --git a/refs.c b/refs.c index b202dca904..8cac7e7e59 100644 --- a/refs.c +++ b/refs.c @@ -362,12 +362,7 @@ int refname_is_safe(const char *refname) return result; } - do { - if (!isupper(*refname) && *refname != '_') - return 0; - refname++; - } while (*refname); - return 1; + return is_pseudoref_syntax(refname); } /*
The open-coded logic in refname_is_safe() predates the addition of is_pseudoref_syntax(). But now that we have it, we can make use of it. This shortens the code, but also makes sure we use a consistent definition of a pseudoref. Note that refname_is_safe() allows HEAD, which of course is not itself a pseudoref by the strict definition (since it can be a symref). But the syntax for the two is the same, and that is all that we care about here. Signed-off-by: Jeff King <peff@peff.net> --- refs.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)