| Message ID | 20240710083557.GC2060601@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d558509e2527abaf0faf1f93cad775eeeada0d17 |
| Headers | show |
| Series | here-doc test bodies (now with 100% more chainlinting) | expand |
diff --git a/t/chainlint.pl b/t/chainlint.pl index 1864d048ae..118a229a96 100755 --- a/t/chainlint.pl +++ b/t/chainlint.pl @@ -806,6 +806,7 @@ sub exit_code { show_stats($start_time, \@stats) if $show_stats; exit; } +$jobs = @scripts if @scripts < $jobs; unless ($jobs > 1 && $Config{useithreads} && eval {
The chainlint.pl script spawns worker threads to check many scripts in parallel. This is good if you feed it a lot of scripts. But if you give it few (or one), then the overhead of spawning the threads dominates. We can easily notice that we have fewer scripts than threads and scale back as appropriate. This patch reduces the time to run: time for i in chainlint/*.test; do perl chainlint.pl $i done >/dev/null on my system from ~4.1s to ~1.1s, where I have 8+8 cores. As with the previous patch, this isn't the usual way we run chainlint (we feed many scripts at once, which is why it supports threading in the first place). So this won't make a big difference in the real world, but it may help us out in the future, and it makes experimenting with and debugging the chainlint tests a bit more pleasant. Signed-off-by: Jeff King <peff@peff.net> --- t/chainlint.pl | 1 + 1 file changed, 1 insertion(+)