diff mbox series

[04/15] refs: mark unused parameters in do_for_each_reflog_helper()

Message ID 20240817082222.GD10287@coredump.intra.peff.net (mailing list archive)
State Accepted
Commit bdc71b43ee2599eb7d361b481f6aadd7ad21e7c5
Headers show
Series marking some more unused parameters | expand

Commit Message

Jeff King Aug. 17, 2024, 8:22 a.m. UTC
This is an each_ref_fn callback, so it has to match that interface. We
marked most of these in 63e14ee2d6 (refs: mark unused each_ref_fn
parameters, 2022-08-19), but in this case:

  - this function was created in 31f898397b (refs: drop unused params
    from the reflog iterator callback, 2024-02-21), and most of the
    arguments were correctly mark as UNUSED, but "flags" was missed.

  - commit e8207717f1 (refs: add referent to each_ref_fn, 2024-08-09)
    added a new argument to the each_ref_fn callback. In most callbacks
    it added an UNUSED annotation, but it missed one case.

Signed-off-by: Jeff King <peff@peff.net>
---
 refs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/refs.c b/refs.c
index 74de3d3009..584674520e 100644
--- a/refs.c
+++ b/refs.c
@@ -2390,9 +2390,10 @@  struct do_for_each_reflog_help {
 	void *cb_data;
 };
 
-static int do_for_each_reflog_helper(const char *refname, const char *referent,
+static int do_for_each_reflog_helper(const char *refname,
+				     const char *referent UNUSED,
 				     const struct object_id *oid UNUSED,
-				     int flags,
+				     int flags UNUSED,
 				     void *cb_data)
 {
 	struct do_for_each_reflog_help *hp = cb_data;