diff mbox series

[4/6] compat: disable -Wunused-parameter in win32/headless.c

Message ID 20240828035952.GD3999193@coredump.intra.peff.net (mailing list archive)
State Accepted
Commit 141491840d4efb0a24430eea6815dc8164786820
Headers show
Series unused parameters: the final countdown | expand

Commit Message

Jeff King Aug. 28, 2024, 3:59 a.m. UTC
As with the files touched in the previous commit, win32/headless.c does
not include git-compat-util.h, so it doesn't have our UNUSED macro.
Unlike those ones, this is not third-party code, so it would not be a
big deal to modify it.

However, I'm not sure if including git-compat-util.h would create other
headaches (and I don't even have a machine to test this on; I'm relying
on Windows CI to compile it at all). Given how trivial the file is, and
that the unused parameters are not interesting (they are just
boilerplate for the wWinMain() function), we can just use the same trick
as the previous commit and disable the warnings via pragma.

Signed-off-by: Jeff King <peff@peff.net>
---
 compat/win32/headless.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/compat/win32/headless.c b/compat/win32/headless.c
index 8b00dfe3bd..11392a0b9a 100644
--- a/compat/win32/headless.c
+++ b/compat/win32/headless.c
@@ -11,6 +11,8 @@ 
 #include <stdlib.h>
 #include <wchar.h>
 
+#pragma GCC diagnostic ignored "-Wunused-parameter"
+
 /*
  * If `dir` contains the path to a Git exec directory, extend `PATH` to
  * include the corresponding `bin/` directory (which is where all those