Message ID | 20241018052952.GE2408674@coredump.intra.peff.net (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | credential-cache: treat ECONNABORTED like ECONNRESET | expand |
On Fri, Oct 18, 2024 at 01:29:52AM -0400, Jeff King wrote: > On Fri, Oct 18, 2024 at 06:36:11AM +0200, Patrick Steinhardt wrote: > > > Subject: builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin > > I think this commit message has a few unclear or inaccurate bits, > because it's based on the earlier attempt. E.g., the change is now on > the client side, not in credential-cache--daemon. > > And I think rather than say "the daemon exit rules are intricate", we > can actually outline the rules. :) > > So here's what I had written after reading through the old thread. It > would preferably get Ramsay's Signed-off-by before being applied. Works for me. I don't really care whose patch lands, I just want the issue to be fixed :) Thanks! Patrick
diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c index 5de8b9123b..7789d57d3e 100644 --- a/builtin/credential-cache.c +++ b/builtin/credential-cache.c @@ -30,7 +30,7 @@ static int connection_fatally_broken(int error) static int connection_closed(int error) { - return (error == ECONNRESET); + return error == ECONNRESET || error == ECONNABORTED; } static int connection_fatally_broken(int error)