[v2,05/14] config.mak.dev: drop `-Wno-sign-compare`

Message ID	20241202-pks-sign-compare-v2-5-e7f0ad92a749@pks.im (mailing list archive)
State	Superseded
Headers	show Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE124204F92 for <git@vger.kernel.org>; Mon, 2 Dec 2024 12:05:04 +0000 (UTC) Feedback-ID: i197146af:Fastmail From: Patrick Steinhardt <ps@pks.im> Date: Mon, 02 Dec 2024 13:04:37 +0100 Subject: [PATCH v2 05/14] config.mak.dev: drop `-Wno-sign-compare` Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20241202-pks-sign-compare-v2-5-e7f0ad92a749@pks.im> References: <20241202-pks-sign-compare-v2-0-e7f0ad92a749@pks.im> In-Reply-To: <20241202-pks-sign-compare-v2-0-e7f0ad92a749@pks.im> To: git@vger.kernel.org Cc: shejialuo <shejialuo@gmail.com>, Jeff King <peff@peff.net>
Series	Start compiling with `-Wsign-compare` \| expand [v2,00/14] Start compiling with `-Wsign-compare` [v2,01/14] git-compat-util: introduce macros to disable "-Wsign-compare" warnings [v2,02/14] compat/regex: explicitly ignore "-Wsign-compare" warnings [v2,03/14] compat/win32: fix -Wsign-compare warning in "wWinMain()" [v2,04/14] global: mark code units that generate warnings with `-Wsign-compare` [v2,05/14] config.mak.dev: drop `-Wno-sign-compare` [v2,06/14] diff.h: fix index used to loop through unsigned integer [v2,07/14] global: trivial conversions to fix `-Wsign-compare` warnings [v2,08/14] daemon: fix loops that have mismatching integer types [v2,09/14] daemon: fix type of `max_connections` [v2,10/14] gpg-interface: address -Wsign-comparison warnings [v2,11/14] builtin/blame: fix type of `length` variable when emitting object ID [v2,12/14] builtin/patch-id: fix type of `get_one_patchid()` [v2,13/14] scalar: address -Wsign-compare warnings [v2,14/14] t/helper: don't depend on implicit wraparound

Message ID

20241202-pks-sign-compare-v2-5-e7f0ad92a749@pks.im (mailing list archive)

State

Superseded

Headers

Feedback-ID: i197146af:Fastmail
From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 02 Dec 2024 13:04:37 +0100
Subject: [PATCH v2 05/14] config.mak.dev: drop `-Wno-sign-compare`
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20241202-pks-sign-compare-v2-5-e7f0ad92a749@pks.im>
References: <20241202-pks-sign-compare-v2-0-e7f0ad92a749@pks.im>
In-Reply-To: <20241202-pks-sign-compare-v2-0-e7f0ad92a749@pks.im>
To: git@vger.kernel.org
Cc: shejialuo <shejialuo@gmail.com>, Jeff King <peff@peff.net>

Series

Start compiling with `-Wsign-compare` | expand

Commit Message

Patrick Steinhardt Dec. 2, 2024, 12:04 p.m. UTC

There is no need anymore to disable `-Wsign-compare` now that all files
that cause warnings have been marked accordingly. Drop the option.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 config.mak.dev | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config.mak.dev b/config.mak.dev
index 8eca7fa22823b46ebdf02b73d53031784fd5ba2a..0fd8cc4d355ebb7428e1d8258154926dedf8827b 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -53,7 +53,6 @@  ifeq ($(filter extra-all,$(DEVOPTS)),)
 # These are disabled because we have these all over the place.
 DEVELOPER_CFLAGS += -Wno-empty-body
 DEVELOPER_CFLAGS += -Wno-missing-field-initializers
-DEVELOPER_CFLAGS += -Wno-sign-compare
 endif
 endif

[v2,05/14] config.mak.dev: drop `-Wno-sign-compare`

Commit Message

Patch