diff mbox series

[5/6] xdiff: avoid signed vs. unsigned comparisons in xpatience.c

Message ID 20250212060418.1645241-5-davvid@gmail.com (mailing list archive)
State Accepted
Commit 13b67f15c13d2e45215da8950f31ef27645733c3
Headers show
Series [1/6] xdiff: move sign comparison warning guard into each file | expand

Commit Message

David Aguilar Feb. 12, 2025, 6:04 a.m. UTC 
The loop iteration variable is non-negative and used in comparisons
against a size_t value. Use size_t to eliminate the mismatch.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 xdiff/xpatience.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/xdiff/xpatience.c b/xdiff/xpatience.c
index b0ba421b28..82f663004e 100644
--- a/xdiff/xpatience.c
+++ b/xdiff/xpatience.c
@@ -20,8 +20,6 @@ 
  *
  */
 
-#define DISABLE_SIGN_COMPARE_WARNINGS
-
 #include "xinclude.h"
 
 /*
@@ -78,7 +76,7 @@  struct hashmap {
 
 static int is_anchor(xpparam_t const *xpp, const char *line)
 {
-	int i;
+	size_t i;
 	for (i = 0; i < xpp->anchors_nr; i++) {
 		if (!strncmp(line, xpp->anchors[i], strlen(xpp->anchors[i])))
 			return 1;