[v3,14/21] builtin/credential: clear credential before exit

Message ID	265665fe6cb7dc56bb637624910369f2bd0525e8.1716810168.git.ps@pks.im (mailing list archive)
State	Accepted
Commit	96c1655095ae21040afe9d9c05cf42bb0fc03581
Headers	show Received: from wfhigh8-smtp.messagingengine.com (wfhigh8-smtp.messagingengine.com [64.147.123.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCFB715DBD8 for <git@vger.kernel.org>; Mon, 27 May 2024 11:46:54 +0000 (UTC) Feedback-ID: i197146af:Fastmail Date: Mon, 27 May 2024 13:46:49 +0200 From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Cc: Eric Sunshine <sunshine@sunshineco.com>, Junio C Hamano <gitster@pobox.com>, Karthik Nayak <karthik.188@gmail.com>, Jeff King <peff@peff.net> Subject: [PATCH v3 14/21] builtin/credential: clear credential before exit Message-ID: <265665fe6cb7dc56bb637624910369f2bd0525e8.1716810168.git.ps@pks.im> References: <cover.1716465556.git.ps@pks.im> <cover.1716810168.git.ps@pks.im> Precedence: bulk MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ymVMg5F85oph3Fkl" Content-Disposition: inline In-Reply-To: <cover.1716810168.git.ps@pks.im>
Series	Various memory leak fixes \| expand [v3,00/21] Various memory leak fixes [v3,01/21] ci: add missing dependency for TTY prereq [v3,02/21] t: mark a bunch of tests as leak-free [v3,03/21] transport-helper: fix leaking helper name [v3,04/21] strbuf: fix leak when `appendwholeline()` fails with EOF [v3,05/21] checkout: clarify memory ownership in `unique_tracking_name()` [v3,06/21] http: refactor code to clarify memory ownership [v3,07/21] config: clarify memory ownership in `git_config_pathname()` [v3,08/21] diff: refactor code to clarify memory ownership of prefixes [v3,09/21] convert: refactor code to clarify ownership of check_roundtrip_encoding [v3,10/21] builtin/log: stop using globals for log config [v3,11/21] builtin/log: stop using globals for format config [v3,12/21] config: clarify memory ownership in `git_config_string()` [v3,13/21] config: plug various memory leaks [v3,14/21] builtin/credential: clear credential before exit [v3,15/21] commit-reach: fix memory leak in `ahead_behind()` [v3,16/21] submodule: fix leaking memory for submodule entries [v3,17/21] strvec: add functions to replace and remove strings [v3,18/21] builtin/mv: refactor `add_slash()` to always return allocated strings [v3,19/21] builtin/mv duplicate string list memory [v3,20/21] builtin/mv: refactor to use `struct strvec` [v3,21/21] builtin/mv: fix leaks for submodule gitfile paths

Message ID

265665fe6cb7dc56bb637624910369f2bd0525e8.1716810168.git.ps@pks.im (mailing list archive)

State

Accepted

Commit

96c1655095ae21040afe9d9c05cf42bb0fc03581

Headers

Feedback-ID: i197146af:Fastmail
Date: Mon, 27 May 2024 13:46:49 +0200
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	Junio C Hamano <gitster@pobox.com>,
	Karthik Nayak <karthik.188@gmail.com>, Jeff King <peff@peff.net>
Subject: [PATCH v3 14/21] builtin/credential: clear credential before exit
Message-ID: 
 <265665fe6cb7dc56bb637624910369f2bd0525e8.1716810168.git.ps@pks.im>
References: <cover.1716465556.git.ps@pks.im>
 <cover.1716810168.git.ps@pks.im>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ymVMg5F85oph3Fkl"
Content-Disposition: inline
In-Reply-To: <cover.1716810168.git.ps@pks.im>

Series

Various memory leak fixes | expand

Commit Message

Patrick Steinhardt May 27, 2024, 11:46 a.m. UTC

We never release memory associated with `struct credential`. Fix this
and mark the corresponding test as leak free.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 builtin/credential.c   | 2 ++
 t/t0300-credentials.sh | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/builtin/credential.c b/builtin/credential.c
index 5100d441f2..b72e76dd9a 100644
--- a/builtin/credential.c
+++ b/builtin/credential.c
@@ -39,5 +39,7 @@  int cmd_credential(int argc, const char **argv, const char *prefix UNUSED)
 	} else {
 		usage(usage_msg);
 	}
+
+	credential_clear(&c);
 	return 0;
 }
diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
index 432f029d48..6a76b7fdbd 100755
--- a/t/t0300-credentials.sh
+++ b/t/t0300-credentials.sh
@@ -1,6 +1,8 @@ 
 #!/bin/sh
 
 test_description='basic credential helper tests'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh

[v3,14/21] builtin/credential: clear credential before exit

Commit Message

Patch