From patchwork Mon Mar 15 13:14:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 12139215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C1BC43381 for ; Mon, 15 Mar 2021 13:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FF2264EF2 for ; Mon, 15 Mar 2021 13:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhCONOx (ORCPT ); Mon, 15 Mar 2021 09:14:53 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52337 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbhCONOe (ORCPT ); Mon, 15 Mar 2021 09:14:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E66B85C0181; Mon, 15 Mar 2021 09:14:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 15 Mar 2021 09:14:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=/+jiUPbs495isgCRZn2Y3WR6/bP Ft/z94SXdT6KzY1w=; b=Jb2BbjI+vn+2ujrwtJV8J3KTlSeRBUGTItIrmjZ/sbK 6F0bToPLyc/xCLXg8zUOJHwmAbKHGVx9LGWOdOBMqtuT03oU33LdI+M0bzHv7oQF 4XDtcOa2rvTiEXxhE3naaZVzZTTmE/oxCqcX+U0yQMGYvpUqMB4ieWlJCSLHD0jc /gpvnLolcnIhYDdQobcGSABSdlH+czgdWxnpRziRSMzLAgHuBhaZj8DQ/e+FtbX/ YPZtyx05HSoTe7f3aIXrz8KgDIeM3LKVSbCUoSKYZiQKgsj/7D+EDxYeowCXY+EF zm9M+madT8Z9XHQXF5kC5Ze+5IIVLa1Ifqd3M8cq0QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/+jiUP bs495isgCRZn2Y3WR6/bPFt/z94SXdT6KzY1w=; b=lHg/8TAMFTNlv3Hp0M3ftI feK9FgtrRD1c1l0okwsdDuHghhffJAgX20icxfVlBp2V2YFEXzYgOymrr3czda7z 6jzZavBfYD8Wy2YJ1doMDpgk/Ucm6E21hZfbcYox9kWn7pcCgcJD8RERdebVclsF CS/5GyanhLD27HVJhuUniu0IJLpwaHiv/skyAMASeXsRf8ZmYiirq9nGl4pPNFak 1FEdNAIgyfxoKytgHWaU1G9lsC23tbCLYUmX2V97pMG9Wzms2tQPnXmECAJjetke Ss0itAQ/URmNDQ5Ml0F56GcjeezVcG/Bk/YO//hmcDzTu3cR/LgOv77BdqPYcvUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvledggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepkeelrddugedrleeirddvgedunecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (dynamic-089-014-096-241.89.14.pool.telefonica.de [89.14.96.241]) by mail.messagingengine.com (Postfix) with ESMTPA id 42F981080067; Mon, 15 Mar 2021 09:14:33 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 2e00912c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 15 Mar 2021 13:14:32 +0000 (UTC) Date: Mon, 15 Mar 2021 14:14:31 +0100 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Christian Couder , Taylor Blau , Jeff King Subject: [PATCH v2 1/8] uploadpack.txt: document implication of `uploadpackfilter.allow` Message-ID: <270ff80dacff96f441e12954b059a68300157f2d.1615813673.git.ps@pks.im> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org When `uploadpackfilter.allow` is set to `true`, it means that filters are enabled by default except in the case where a filter is explicitly disabled via `uploadpackilter..allow`. This option will not only enable the currently supported set of filters, but also any filters which get added in the future. As such, an admin which wants to have tight control over which filters are allowed and which aren't probably shouldn't ever set `uploadpackfilter.allow=true`. Amend the documentation to make the ramifications more explicit so that admins are aware of this. Signed-off-by: Patrick Steinhardt --- Documentation/config/uploadpack.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt index b0d761282c..6729a072ea 100644 --- a/Documentation/config/uploadpack.txt +++ b/Documentation/config/uploadpack.txt @@ -59,7 +59,8 @@ uploadpack.allowFilter:: uploadpackfilter.allow:: Provides a default value for unspecified object filters (see: the - below configuration variable). + below configuration variable). If set to `true`, this will also + enable all filters which get added in the future. Defaults to `true`. uploadpackfilter..allow::