@@ -1141,7 +1141,7 @@ static int get_first_good(const char *refname UNUSED,
return 1;
}
-static int do_bisect_run(const char *command, int argc UNUSED, const char **argv UNUSED)
+static int do_bisect_run(const char *command)
{
struct child_process cmd = CHILD_PROCESS_INIT;
const char *trimed = command;
@@ -1154,7 +1154,7 @@ static int do_bisect_run(const char *command, int argc UNUSED, const char **argv
return run_command(&cmd);
}
-static int verify_good(const struct bisect_terms *terms, const char *command, int argc, const char **argv)
+static int verify_good(const struct bisect_terms *terms, const char *command)
{
int rc;
enum bisect_error res;
@@ -1174,7 +1174,7 @@ static int verify_good(const struct bisect_terms *terms, const char *command, in
if (res != BISECT_OK)
return -1;
- rc = do_bisect_run(command, argc, argv);
+ rc = do_bisect_run(command);
res = bisect_checkout(¤t_rev, no_checkout);
if (res != BISECT_OK)
@@ -1201,7 +1201,7 @@ static int bisect_run(struct bisect_terms *terms, const char **argv, int argc)
sq_quote_argv(&command, argv);
while (1) {
- res = do_bisect_run(command.buf, argc, argv);
+ res = do_bisect_run(command.buf);
/*
* Exit code 126 and 127 can either come from the shell
@@ -1211,7 +1211,7 @@ static int bisect_run(struct bisect_terms *terms, const char **argv, int argc)
* missing or non-executable script.
*/
if (is_first_run && (res == 126 || res == 127)) {
- int rc = verify_good(terms, command.buf, argc, argv);
+ int rc = verify_good(terms, command.buf);
is_first_run = 0;
if (rc < 0) {
error(_("unable to verify '%s' on good"
Those arguments become unused with previous commit, let's remove them now. This effectively reverts commit HEAD~3. Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> --- builtin/bisect--helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)