From patchwork Mon Mar 30 13:46:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11465543 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B5583159A for ; Mon, 30 Mar 2020 13:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91F0E20776 for ; Mon, 30 Mar 2020 13:46:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="fHhjlmPe"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ERaHyvlF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728080AbgC3Nqj (ORCPT ); Mon, 30 Mar 2020 09:46:39 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:40465 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727954AbgC3Nqj (ORCPT ); Mon, 30 Mar 2020 09:46:39 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 9CE02622; Mon, 30 Mar 2020 09:46:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 30 Mar 2020 09:46:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=iwZsX6lhLXdKSuczgsbqmfQ2IrP FMNmSdEex3+ZPJng=; b=fHhjlmPe69q9re56f8PWmcJHq71I4LS9Mbq3BG3TBSC 8kwswD/t7xLgy/9VK/bqCYyfrgNggQn6Fc6qUCnQgeHahIsDXHYZWSbFy5BLVPwY mUzvH99tsq5pfrJbBHyBCO3hblL3+I9BU2u7GPBlDs5Uwmvr7f7WOx/J1q1NXjDR oZ1UQ1lz5FtehmVirhscVT7MX/qAgEh3GkZsL65irEH1PbS6DcoLCOJPdbmQadB3 7ovfGYG+KWujg/ByylJADsAChtjGdq7dX2GV22m8Q9nhXQoqj7X052KUfre/Yw7l KMVVcg9bFUE4r3vr7yGpF+r7YI1doYwkl6x4g1AycXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=iwZsX6 lhLXdKSuczgsbqmfQ2IrPFMNmSdEex3+ZPJng=; b=ERaHyvlFF9dcm8WWznwYLU 1b37NFMVwB1QMulFUJAHcXg5ug0xZtZor2oA1yxYqMyRwlEewlLUOuFDQ+eK3fgb 7rsJdT5CUbE9o1Nm+pc2yxxX+KZdzCf7lzKwRUcD7acxnHk8wIBVt9K2WvkOkWwd 9mvRWkeizEa4325cqE2E1jyT6VsDkdwiqC4VatvKv0PZzay1Q5W7xqMN7Tjr1xlu SrBVIOd4y0oj7CEJwnwmP3fuoPnrjOG6uPjvq/SiOy1Mdi1Rj0zPp1pEY5TcygQU a/FNNZBfDHrvTkdqBWMwR6oLJcUCg4liGIcHM6u88gdqxVvx0MDx9DYcKYIlzclQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeihedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepjeekrdehge drvddvtddruddtvdenucevlhhushhtvghrufhiiigvpeehnecurfgrrhgrmhepmhgrihhl fhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4e36dc66.dyn.telefonica.de [78.54.220.102]) by mail.messagingengine.com (Postfix) with ESMTPA id 86579328005D; Mon, 30 Mar 2020 09:46:37 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 53a19b53 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 30 Mar 2020 13:46:36 +0000 (UTC) Date: Mon, 30 Mar 2020 15:46:40 +0200 From: Patrick Steinhardt To: git Cc: Christian Couder , Junio C Hamano Subject: [PATCH v2 5/9] update-ref: drop unused argument for `parse_refname` Message-ID: <49a14d20462bb9d7f00e42df73fc21b050be1db0.1585575749.git.ps@pks.im> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The `parse_refname` function accepts a `struct strbuf *input` argument that isn't used at all. As we're about to convert commands to not use a strbuf anymore but instead an end pointer, let's drop this argument now to make the converting commit easier to review. Signed-off-by: Patrick Steinhardt --- builtin/update-ref.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 559475681e..6f2aba916b 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -50,7 +50,7 @@ static const char *parse_arg(const char *next, struct strbuf *arg) * the argument. Die if C-quoting is malformed or the reference name * is invalid. */ -static char *parse_refname(struct strbuf *input, const char **next) +static char *parse_refname(const char **next) { struct strbuf ref = STRBUF_INIT; @@ -189,7 +189,7 @@ static const char *parse_cmd_update(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("update: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("update: missing "); @@ -226,7 +226,7 @@ static const char *parse_cmd_create(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("create: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("create: missing "); @@ -262,7 +262,7 @@ static const char *parse_cmd_delete(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("delete: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("delete: missing "); @@ -300,7 +300,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("verify: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("verify: missing ");