| Message ID | 51b782bb9b6270a0b1f69df8fe9e2e4f5aead2a2.1616414951.git.avarab@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Makefile/coccicheck: fix bugs and speed it up | expand |
Am 22.03.21 um 13:11 schrieb Ævar Arnfjörð Bjarmason: > Change the "xargs -n X" limit for running spatch from 1 to 8, as > suggested by Jeff King[1]. Now that we're not using --all-includes > anymore this is going to take much less memory, so bumping the limit > should be OK. But --all-includes is still used, so does this patch still make sense? > > 1. https://lore.kernel.org/git/YEIGzXMDax83cwAx@coredump.intra.peff.net/ > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index eaac14275bb..543fe472482 100644 > --- a/Makefile > +++ b/Makefile > @@ -1204,7 +1204,7 @@ SPATCH_FLAGS = --all-includes --include-headers-for-types --patch . > # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will > # usually result in less CPU usage at the cost of higher peak memory. > # Setting it to 0 will feed all files in a single spatch invocation. > -SPATCH_BATCH_SIZE = 1 > +SPATCH_BATCH_SIZE = 8 > > # For the 'coccicheck' target; SPATCH_XARGS can be used to manually > # tweak the xargs invocation. By default we invoke "xargs -n 1", and >
On Mon, Mar 22, 2021 at 07:05:12PM +0100, René Scharfe. wrote: > Am 22.03.21 um 13:11 schrieb Ævar Arnfjörð Bjarmason: > > Change the "xargs -n X" limit for running spatch from 1 to 8, as > > suggested by Jeff King[1]. Now that we're not using --all-includes > > anymore this is going to take much less memory, so bumping the limit > > should be OK. > > But --all-includes is still used, so does this patch still make sense? I got similar results on the state before this series (using just --all-includes). So presumably it holds up. I'm not at all convinced, though, that this isn't simply unique to my system, or to a version of spatch. -Peff
diff --git a/Makefile b/Makefile index eaac14275bb..543fe472482 100644 --- a/Makefile +++ b/Makefile @@ -1204,7 +1204,7 @@ SPATCH_FLAGS = --all-includes --include-headers-for-types --patch . # For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will # usually result in less CPU usage at the cost of higher peak memory. # Setting it to 0 will feed all files in a single spatch invocation. -SPATCH_BATCH_SIZE = 1 +SPATCH_BATCH_SIZE = 8 # For the 'coccicheck' target; SPATCH_XARGS can be used to manually # tweak the xargs invocation. By default we invoke "xargs -n 1", and
Change the "xargs -n X" limit for running spatch from 1 to 8, as suggested by Jeff King[1]. Now that we're not using --all-includes anymore this is going to take much less memory, so bumping the limit should be OK. 1. https://lore.kernel.org/git/YEIGzXMDax83cwAx@coredump.intra.peff.net/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)