| Message ID | 53c6348035360912a9d720448dceb17895703da2.1701242407.git.ps@pks.im (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 54087dd32be83c47599f39d3a40259e251ed2b8a |
| Headers | show |
| Series | t: more compatibility fixes with reftables | expand |
On Wed, Nov 29, 2023 at 08:24:40AM +0100, Patrick Steinhardt wrote: > Two of our tests in t0410 verify whether partial clones end up with the > correct repository format version and extensions. These checks require > the reffiles backend because every other backend would by necessity bump > the repository format version to be at least 1. > > Mark the tests accordingly. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > t/t0410-partial-clone.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh > index 5b7bee888d..6b6424b3df 100755 > --- a/t/t0410-partial-clone.sh > +++ b/t/t0410-partial-clone.sh > @@ -49,7 +49,7 @@ test_expect_success 'convert shallow clone to partial clone' ' > test_cmp_config -C client 1 core.repositoryformatversion > ' > > -test_expect_success SHA1 'convert to partial clone with noop extension' ' > +test_expect_success SHA1,REFFILES 'convert to partial clone with noop extension' ' I thought for a second that the SHA1 prerequisite would cover this already, but that's not right since you can be in SHA1 mode even if your repositoryformatversion is 1. So this change makes sense to me and is well-reasoned. Thanks, Taylor
diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 5b7bee888d..6b6424b3df 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial-clone.sh @@ -49,7 +49,7 @@ test_expect_success 'convert shallow clone to partial clone' ' test_cmp_config -C client 1 core.repositoryformatversion ' -test_expect_success SHA1 'convert to partial clone with noop extension' ' +test_expect_success SHA1,REFFILES 'convert to partial clone with noop extension' ' rm -fr server client && test_create_repo server && test_commit -C server my_commit 1 && @@ -60,7 +60,7 @@ test_expect_success SHA1 'convert to partial clone with noop extension' ' git -C client fetch --unshallow --filter="blob:none" ' -test_expect_success SHA1 'converting to partial clone fails with unrecognized extension' ' +test_expect_success SHA1,REFFILES 'converting to partial clone fails with unrecognized extension' ' rm -fr server client && test_create_repo server && test_commit -C server my_commit 1 &&
Two of our tests in t0410 verify whether partial clones end up with the correct repository format version and extensions. These checks require the reffiles backend because every other backend would by necessity bump the repository format version to be at least 1. Mark the tests accordingly. Signed-off-by: Patrick Steinhardt <ps@pks.im> --- t/t0410-partial-clone.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)