| Message ID | 5729dd380708da7b40805f75c5d475ff4c0b28c5.1573013889.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | t: fix typo in test descriptions | expand |
On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote: > From: Nathan Stocks <cleancut@github.com> > > Fix two test descriptions which stated "git -ls-files" when the actual > command being tested was "git ls-files". Thanks, this is obviously an improvement. I was curious if there was any backstory here. They came from 54e1abce90 (Add test case for ls-files --with-tree, 2007-10-03). That was around the time of transitioning from "git-ls-files" to "git ls-files", so maybe that caused the confusion. :) -Peff
That would make sense. It would be easy to add a space and forget to remove the hyphen. ~ Nathan On Tue, Nov 5, 2019 at 9:28 PM Jeff King <peff@peff.net> wrote: > > On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote: > > > From: Nathan Stocks <cleancut@github.com> > > > > Fix two test descriptions which stated "git -ls-files" when the actual > > command being tested was "git ls-files". > > Thanks, this is obviously an improvement. > > I was curious if there was any backstory here. They came from 54e1abce90 > (Add test case for ls-files --with-tree, 2007-10-03). That was around > the time of transitioning from "git-ls-files" to "git ls-files", so > maybe that caused the confusion. :) > > -Peff
Hi Nathan, On Wed, Nov 06, 2019 at 04:18:09AM +0000, Nathan Stocks via GitGitGadget wrote: > From: Nathan Stocks <cleancut@github.com> > > Fix two test descriptions which stated "git -ls-files" when the actual > command being tested was "git ls-files". > > Signed-off-by: Nathan Stocks <cleancut@github.com> > --- > t/t3060-ls-files-with-tree.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Nice find. I agree with your and Peff's conclusion about when these might have been introduced, so that they have survived so long indicates that this was an especially good find indeed. Your patch looks great to me. Reviewed-by: Taylor Blau <me@ttaylorr.com> > diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh > index 44f378ce41..52ed665fcd 100755 > --- a/t/t3060-ls-files-with-tree.sh > +++ b/t/t3060-ls-files-with-tree.sh > @@ -47,7 +47,7 @@ test_expect_success setup ' > git add . > ' > > -test_expect_success 'git -ls-files --with-tree should succeed from subdir' ' > +test_expect_success 'git ls-files --with-tree should succeed from subdir' ' > # We have to run from a sub-directory to trigger prune_path > # Then we finally get to run our --with-tree test > ( > @@ -57,7 +57,7 @@ test_expect_success 'git -ls-files --with-tree should succeed from subdir' ' > ' > > test_expect_success \ > - 'git -ls-files --with-tree should add entries from named tree.' \ > + 'git ls-files --with-tree should add entries from named tree.' \ > 'test_cmp expected output' > > test_done > -- > gitgitgadget Thanks, Taylor
On Wed, Nov 6, 2019 at 12:37 AM Taylor Blau <me@ttaylorr.com> wrote: > Nice find. I agree with your and Peff's conclusion about when these > might have been introduced, so that they have survived so long indicates > that this was an especially good find indeed. > > Your patch looks great to me. > > Reviewed-by: Taylor Blau <me@ttaylorr.com> Great, thanks! ~ Nathan
diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh index 44f378ce41..52ed665fcd 100755 --- a/t/t3060-ls-files-with-tree.sh +++ b/t/t3060-ls-files-with-tree.sh @@ -47,7 +47,7 @@ test_expect_success setup ' git add . ' -test_expect_success 'git -ls-files --with-tree should succeed from subdir' ' +test_expect_success 'git ls-files --with-tree should succeed from subdir' ' # We have to run from a sub-directory to trigger prune_path # Then we finally get to run our --with-tree test ( @@ -57,7 +57,7 @@ test_expect_success 'git -ls-files --with-tree should succeed from subdir' ' ' test_expect_success \ - 'git -ls-files --with-tree should add entries from named tree.' \ + 'git ls-files --with-tree should add entries from named tree.' \ 'test_cmp expected output' test_done