[v3,15/22] t1407: require REFFILES for for_each_reflog test

Message ID	57fcd175fa723cec194ddf776d6e209ae0f27d74.1622480197.git.gitgitgadget@gmail.com (mailing list archive)
State	Accepted
Commit	759d02d1aeb2e9d51afe9f948fe0dc15093722a0
Headers	show Return-Path: <git-owner@kernel.org> Message-Id: <57fcd175fa723cec194ddf776d6e209ae0f27d74.1622480197.git.gitgitgadget@gmail.com> In-Reply-To: <pull.1008.v3.git.git.1622480197.gitgitgadget@gmail.com> References: <pull.1008.v2.git.git.1619519903.gitgitgadget@gmail.com> <pull.1008.v3.git.git.1622480197.gitgitgadget@gmail.com> Date: Mon, 31 May 2021 16:56:30 +0000 Subject: [PATCH v3 15/22] t1407: require REFFILES for for_each_reflog test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fcc: Sent To: git@vger.kernel.org Cc: SZEDER =?utf-8?b?R8OhYm9y?= <szeder.dev@gmail.com>, =?utf-8?b?w4Z2YXIg?= =?utf-8?b?QXJuZmrDtnLDsA==?= Bjarmason <avarab@gmail.com>, Han-Wen Nienhuys <hanwen@google.com>, Han-Wen Nienhuys <hanwenn@gmail.com>, Han-Wen Nienhuys <hanwen@google.com> Precedence: bulk From: Han-Wen Nienhuys <hanwen@google.com>
Series	Prepare tests for reftable backend \| expand [v3,00/22] Prepare tests for reftable backend [v3,01/22] t4202: split testcase for invalid HEAD symref and HEAD hash [v3,02/22] t/helper/ref-store: initialize oid in resolve-ref [v3,03/22] t9300: check ref existence using test-helper rather than a file system check [v3,04/22] t5601: read HEAD using rev-parse [v3,05/22] t1401: use tar to snapshot and restore repo state [v3,06/22] t1401-symbolic-ref: avoid direct filesystem access [v3,07/22] t1413: use tar to save and restore entire .git directory [v3,08/22] t1301: fix typo in error message [v3,09/22] t5000: reformat indentation to the latest fashion [v3,10/22] t5000: inspect HEAD using git-rev-parse [v3,11/22] t7003: use rev-parse rather than FS inspection [v3,12/22] t5304: restyle: trim empty lines, drop ':' before > [v3,13/22] t5304: use "reflog expire --all" to clear the reflog [v3,14/22] test-lib: provide test prereq REFFILES [v3,15/22] t1407: require REFFILES for for_each_reflog test [v3,16/22] t1414: mark corruption test with REFFILES [v3,17/22] t2017: mark --orphan/logAllRefUpdates=false test as REFFILES [v3,18/22] t1404: mark tests that muck with .git directly as REFFILES. [v3,19/22] t7900: stop checking for loose refs [v3,20/22] t7003: check reflog existence only for REFFILES [v3,21/22] t4202: mark bogus head hash test with REFFILES [v3,22/22] t1415: set REFFILES for test specific to storage format

Message ID

57fcd175fa723cec194ddf776d6e209ae0f27d74.1622480197.git.gitgitgadget@gmail.com (mailing list archive)

State

Accepted

Commit

759d02d1aeb2e9d51afe9f948fe0dc15093722a0

Headers

Message-Id: 
 <57fcd175fa723cec194ddf776d6e209ae0f27d74.1622480197.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.1008.v3.git.git.1622480197.gitgitgadget@gmail.com>
References: <pull.1008.v2.git.git.1619519903.gitgitgadget@gmail.com>
        <pull.1008.v3.git.git.1622480197.gitgitgadget@gmail.com>
Date: Mon, 31 May 2021 16:56:30 +0000
Subject: [PATCH v3 15/22] t1407: require REFFILES for for_each_reflog test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fcc: Sent
To: git@vger.kernel.org
Cc: SZEDER =?utf-8?b?R8OhYm9y?= <szeder.dev@gmail.com>, =?utf-8?b?w4Z2YXIg?=
	=?utf-8?b?QXJuZmrDtnLDsA==?= Bjarmason  <avarab@gmail.com>,
 Han-Wen Nienhuys <hanwen@google.com>, Han-Wen Nienhuys <hanwenn@gmail.com>,
 Han-Wen Nienhuys <hanwen@google.com>
Precedence: bulk
From: Han-Wen Nienhuys <hanwen@google.com>

Series

Prepare tests for reftable backend | expand

Commit Message

Han-Wen Nienhuys May 31, 2021, 4:56 p.m. UTC

From: Han-Wen Nienhuys <hanwen@google.com>

Add extensive comment why this test needs a REFFILES annotation.

I tried forcing universal reflog creation with core.logAllRefUpdates=true, but
that apparently also doesn't cause reflogs to be created for pseudorefs

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t1407-worktree-ref-store.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/t/t1407-worktree-ref-store.sh b/t/t1407-worktree-ref-store.sh
index d3fe77751122..ad8006c81397 100755
--- a/t/t1407-worktree-ref-store.sh
+++ b/t/t1407-worktree-ref-store.sh
@@ -52,7 +52,14 @@  test_expect_success 'create_symref(FOO, refs/heads/main)' '
 	test_cmp expected actual
 '
 
-test_expect_success 'for_each_reflog()' '
+# Some refs (refs/bisect/*, pseudorefs) are kept per worktree, so they should
+# only appear in the for-each-reflog output if it is called from the correct
+# worktree, which is exercised in this test. This test is poorly written (and
+# therefore marked REFFILES) for mulitple reasons: 1) it creates invalidly
+# formatted log entres. 2) it uses direct FS access for creating the reflogs. 3)
+# PSEUDO-WT and refs/bisect/random do not create reflogs by default, so it is
+# not testing a realistic scenario.
+test_expect_success REFFILES 'for_each_reflog()' '
 	echo $ZERO_OID > .git/logs/PSEUDO-MAIN &&
 	mkdir -p     .git/logs/refs/bisect &&
 	echo $ZERO_OID > .git/logs/refs/bisect/random &&

[v3,15/22] t1407: require REFFILES for for_each_reflog test

Commit Message

Patch