| Message ID | 587e339a-8520-48d5-8090-e8d8bfb0c1f4@ramsayjones.plus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f78e2dd88a366875acb40352c80283929ebd8ab4 |
| Headers | show |
| Series | Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS | expand |
diff --git a/Makefile b/Makefile index d6479092a0..ce3ff2476c 100644 --- a/Makefile +++ b/Makefile @@ -1376,7 +1376,7 @@ PTHREAD_CFLAGS = # For the 'sparse' target SPARSE_FLAGS ?= -std=gnu99 -SP_EXTRA_FLAGS = -Wno-universal-initializer +SP_EXTRA_FLAGS = # For informing GIT-BUILD-OPTIONS of the SANITIZE=leak,address targets SANITIZE_LEAK =
Commit 1c96642326 ("sparse: allow '{ 0 }' to be used without warnings", 2020-05-22) added -Wno-universal-initializer to the SP_EXTRA_FLAGS in order to suppress potential sparse warnings from using '{0}' as an aggregate initializer. At that time, the default was for sparse to issue warnings (i.e. the default was -Wuniversal-initializer) if such an initializer was used to initialize an aggregate whose first member was a pointer type. However, this default was changed just a few days later to -Wno-universal-initializer (first released in sparse v0.6.2) and has been so in all subsequent release versions of sparse. Thus, including -Wno-universal-initializer in the SP_EXTRA_FLAGS variable is redundant. Remove the unnecessary warning flag from SP_EXTRA_FLAGS, essentially reverting commit 1c96642326. Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)