[v2,09/20] config: expose `repo_config_clear()`

Message ID	5e73ef6cec809a3f1009d302b8721b56b048898d.1723540226.git.ps@pks.im (mailing list archive)
State	Accepted
Commit	2ea853646807f36ccd8d5c8e30b146c33f4ca3eb
Headers	show Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6211B18C323 for <git@vger.kernel.org>; Tue, 13 Aug 2024 09:13:50 +0000 (UTC) Feedback-ID: i197146af:Fastmail Date: Tue, 13 Aug 2024 11:13:46 +0200 From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Cc: Justin Tobler <jltobler@gmail.com>, Junio C Hamano <gitster@pobox.com> Subject: [PATCH v2 09/20] config: expose `repo_config_clear()` Message-ID: <5e73ef6cec809a3f1009d302b8721b56b048898d.1723540226.git.ps@pks.im> References: <cover.1723013714.git.ps@pks.im> <cover.1723540226.git.ps@pks.im> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1723540226.git.ps@pks.im>
Series	Stop using `the_repository` in "config.c" \| expand [v2,00/20] Stop using `the_repository` in "config.c" [v2,01/20] path: expose `do_git_path()` as `repo_git_pathv()` [v2,02/20] path: expose `do_git_common_path()` as `repo_common_pathv()` [v2,03/20] editor: do not rely on `the_repository` for interactive edits [v2,04/20] hooks: remove implicit dependency on `the_repository` [v2,05/20] path: stop relying on `the_repository` when reporting garbage [v2,06/20] path: stop relying on `the_repository` in `worktree_git_path()` [v2,07/20] path: hide functions using `the_repository` by default [v2,08/20] config: introduce missing setters that take repo as parameter [v2,09/20] config: expose `repo_config_clear()` [v2,10/20] config: pass repo to `git_config_get_index_threads()` [v2,11/20] config: pass repo to `git_config_get_split_index()` [v2,12/20] config: pass repo to `git_config_get_max_percent_split_change()` [v2,13/20] config: pass repo to `git_config_get_expiry()` [v2,14/20] config: pass repo to `git_config_get_expiry_in_days()` [v2,15/20] config: pass repo to `git_die_config()` [v2,16/20] config: pass repo to functions that rename or copy sections [v2,17/20] config: don't have setters depend on `the_repository` [v2,18/20] config: don't depend on `the_repository` with branch conditions [v2,19/20] global: prepare for hiding away repo-less config functions [v2,20/20] config: hide functions using `the_repository` by default

Message ID

5e73ef6cec809a3f1009d302b8721b56b048898d.1723540226.git.ps@pks.im (mailing list archive)

State

Accepted

Commit

2ea853646807f36ccd8d5c8e30b146c33f4ca3eb

Headers

Feedback-ID: i197146af:Fastmail
Date: Tue, 13 Aug 2024 11:13:46 +0200
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Justin Tobler <jltobler@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 09/20] config: expose `repo_config_clear()`
Message-ID: 
 <5e73ef6cec809a3f1009d302b8721b56b048898d.1723540226.git.ps@pks.im>
References: <cover.1723013714.git.ps@pks.im>
 <cover.1723540226.git.ps@pks.im>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1723540226.git.ps@pks.im>

Series

Stop using `the_repository` in "config.c" | expand

Commit Message

Patrick Steinhardt Aug. 13, 2024, 9:13 a.m. UTC

While we already have `repo_config_clear()` as an alternative to
`git_config_clear()` that doesn't rely on `the_repository`, it is not
exposed to callers outside of the config subsystem. Do so.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 config.c | 2 +-
 config.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/config.c b/config.c
index ac89b708e7..476cd73c9e 100644
--- a/config.c
+++ b/config.c
@@ -2564,7 +2564,7 @@  static void git_config_check_init(struct repository *repo)
 	repo_read_config(repo);
 }
 
-static void repo_config_clear(struct repository *repo)
+void repo_config_clear(struct repository *repo)
 {
 	if (!repo->config || !repo->config->hash_initialized)
 		return;
diff --git a/config.h b/config.h
index b13e1bfb8d..8eb3efa0c4 100644
--- a/config.h
+++ b/config.h
@@ -651,6 +651,7 @@  int git_config_get_string_multi(const char *key,
  * Resets and invalidates the config cache.
  */
 void git_config_clear(void);
+void repo_config_clear(struct repository *repo);
 
 /**
  * Allocates and copies the retrieved string into the `dest` parameter for

[v2,09/20] config: expose `repo_config_clear()`

Commit Message

Patch