| Message ID | 6447b11b-f916-4079-8936-8d4f6c480f57@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92e209be78a18e1b36bd0f07d9b99e1790df407c |
| Headers | show |
| Series | mark tests as leak-free | expand |
Rubén Justo <rjusto@gmail.com> writes: > In a recent commit we fixed a test where it was set after sourcing > test-lib.sh, leading to confusing results. OK, the reference is to the previous step. Makes sense. > > To prevent future oversights, let's add a simple check to ensure the > value for TEST_PASSES_SANITIZE_LEAK remains unchanged at test_done(). > > Signed-off-by: Rubén Justo <rjusto@gmail.com> > --- > t/test-lib.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/t/test-lib.sh b/t/test-lib.sh > index fc93aa57e6..042f557a6f 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -1297,6 +1297,11 @@ test_done () { > EOF > fi > > + if test -z "$passes_sanitize_leak" && test_bool_env TEST_PASSES_SANITIZE_LEAK false > + then > + BAIL_OUT "Please, set TEST_PASSES_SANITIZE_LEAK before sourcing test-lib.sh" > + fi > + > if test "$test_fixed" != 0 > then > say_color error "# $test_fixed known breakage(s) vanished; please update test(s)"
diff --git a/t/test-lib.sh b/t/test-lib.sh index fc93aa57e6..042f557a6f 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1297,6 +1297,11 @@ test_done () { EOF fi + if test -z "$passes_sanitize_leak" && test_bool_env TEST_PASSES_SANITIZE_LEAK false + then + BAIL_OUT "Please, set TEST_PASSES_SANITIZE_LEAK before sourcing test-lib.sh" + fi + if test "$test_fixed" != 0 then say_color error "# $test_fixed known breakage(s) vanished; please update test(s)"
TEST_PASSES_SANITIZE_LEAK must be set before sourcing test-lib.sh, as we say in t/README: GIT_TEST_PASSING_SANITIZE_LEAK=true skips those tests that haven't declared themselves as leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh". This test mode is used by the "linux-leaks" CI target. GIT_TEST_PASSING_SANITIZE_LEAK=check checks that our "TEST_PASSES_SANITIZE_LEAK=true" markings are current. Rather than skipping those tests that haven't set "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh" this mode runs them with "--invert-exit-code". This is used to check that there's a one-to-one mapping between "TEST_PASSES_SANITIZE_LEAK=true" and those tests that pass under "SANITIZE=leak". This is especially useful when testing a series that fixes various memory leaks with "git rebase -x". In a recent commit we fixed a test where it was set after sourcing test-lib.sh, leading to confusing results. To prevent future oversights, let's add a simple check to ensure the value for TEST_PASSES_SANITIZE_LEAK remains unchanged at test_done(). Signed-off-by: Rubén Justo <rjusto@gmail.com> --- t/test-lib.sh | 5 +++++ 1 file changed, 5 insertions(+)