From patchwork Mon Apr 17 20:54:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taylor Blau X-Patchwork-Id: 13214711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02533C77B76 for ; Mon, 17 Apr 2023 20:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbjDQU5z (ORCPT ); Mon, 17 Apr 2023 16:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjDQU5c (ORCPT ); Mon, 17 Apr 2023 16:57:32 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75DD210266 for ; Mon, 17 Apr 2023 13:55:15 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-54fbb713301so190263297b3.11 for ; Mon, 17 Apr 2023 13:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20221208.gappssmtp.com; s=20221208; t=1681764874; x=1684356874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zqn+KrQfmAEpBOrH9kb2/2ZRJlyEO5bB4c2oYbqMeTc=; b=3RKClGfSe35LRcG3hTY77Vv39xD2fui0UB40y8w6/2rAnF6DRo4QHWx8cswIjpt8YY +xh2yhaPXKwJTBgdSpgYwv0suMGkR2oj992Tk0EDq9jyaGxp6vG/esJjVql7OPKoSKTU QCXuvmQgw5ogk1VyONyHd/MGWqr3uwtF5gBjfe7gePz5no7ciJFcnjeugUPzyqTsNkK9 1VuNarmLnCiEzxRwC+05myAAu1EN6TeGnlQH6YnyCXfidLLNfuFURkvusMdxPQ3dBNy3 6lZNBfD93hxzn2phOsI+r0kzGXVKIVJPLI888Gm6vYj9FlBd8X5qc8x7SBGHgs+NZVro Hj8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681764874; x=1684356874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zqn+KrQfmAEpBOrH9kb2/2ZRJlyEO5bB4c2oYbqMeTc=; b=bEE1UW1xH4wMLG/FdVTpgmd3GC0PYKdGxNxbTB9Weg1iltBNd1CmqNWbETL+CT6tao kgAd5CIHQIDkgslcW/MjpCdWlNyMGcpq1l9J+iO59hTUSRHeyBT12OBXA7tS3NBcmoIb ZthqIXHvKqFTF8drEkmgboGIbnn41GKxpHEBn3Mu3BTtQJDdfK80vljw9jSH7vGzjyEy yu0gxyOePoetLpRA68U5EPc9BeiyZzyyT/mFprrVkW7GuOE87JFLoglskZmKqbtZNOGC NH9oZaPxggRM++QcfyZ6tMd6rTzzIhm2cGEkIzW7SUOVccsopd+3Ppv9U5oD9ebaWDRY LyBQ== X-Gm-Message-State: AAQBX9cBtcA2Vo7RuGvq+SbxZKTEaiHkx7tAHjwrsgIOKzecnv/0Q7z0 /fWgdkiFAYGQExGkBRRfc5kWJDs+vVhgXB9g40oMDg== X-Google-Smtp-Source: AKy350YvzMpTKpRJtms7IfvK1/PqIcRENmeeu6JEDzaKgiImU24P2KnELB4mUw7hdPuokispgM7OBg== X-Received: by 2002:a81:84d1:0:b0:541:9ac1:f5a9 with SMTP id u200-20020a8184d1000000b005419ac1f5a9mr16123451ywf.2.1681764874550; Mon, 17 Apr 2023 13:54:34 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id j199-20020a8155d0000000b0054f80928ea4sm3305279ywb.140.2023.04.17.13.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 13:54:34 -0700 (PDT) Date: Mon, 17 Apr 2023 16:54:33 -0400 From: Taylor Blau To: git@vger.kernel.org Cc: Jeff King , Derrick Stolee , Junio C Hamano Subject: [PATCH 07/10] t/t6500-gc.sh: add additional test cases Message-ID: <6957e54f51759ff1b6d2469bc40c9b966635595d.1681764848.git.me@ttaylorr.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org In the last commit, we refactored some of the tests in t6500 to make clearer when cruft packs will and won't be generated by `git gc`. Add the remaining cases not covered by the previous patch into this one, which enumerates all possible combinations of arguments that will produce (or not produce) a cruft pack. This prepares us for the following commit, which will change the default of `gc.cruftPacks` by ensuring that we understand which invocations do and do not change as a result. Signed-off-by: Taylor Blau --- t/t6500-gc.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh index a2f988c5c2..e7d3d1448f 100755 --- a/t/t6500-gc.sh +++ b/t/t6500-gc.sh @@ -218,6 +218,7 @@ assert_no_cruft_packs () { for argv in \ "gc --cruft" \ "-c gc.cruftPacks=true gc" \ + "-c gc.cruftPacks=false gc --cruft" \ "-c feature.experimental=true gc" \ "-c gc.cruftPacks=true -c feature.experimental=false gc" do @@ -243,6 +244,9 @@ do done for argv in \ + "gc --no-cruft" \ + "-c gc.cruftPacks=false gc" \ + "-c gc.cruftPacks=true gc --no-cruft" \ "-c feature.expiremental=true -c gc.cruftPacks=false gc" \ "-c feature.experimental=false gc" do