[16/23] builtin/shortlog: fix various trivial memory leaks

Message ID	778e87221ac1d8cc581a8c3f3572810c68686451.1721995576.git.ps@pks.im (mailing list archive)
State	Superseded
Headers	show Received: from fhigh1-smtp.messagingengine.com (fhigh1-smtp.messagingengine.com [103.168.172.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC8D2140E34 for <git@vger.kernel.org>; Fri, 26 Jul 2024 12:17:37 +0000 (UTC) Feedback-ID: i197146af:Fastmail Date: Fri, 26 Jul 2024 14:17:29 +0200 From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Subject: [PATCH 16/23] builtin/shortlog: fix various trivial memory leaks Message-ID: <778e87221ac1d8cc581a8c3f3572810c68686451.1721995576.git.ps@pks.im> References: <cover.1721995576.git.ps@pks.im> Precedence: bulk MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LsdEeTM6MC9Zkyi0" Content-Disposition: inline In-Reply-To: <cover.1721995576.git.ps@pks.im>
Series	Memory leak fixes (pt.3) \| expand [00/23] Memory leak fixes (pt.3) [01/23] builtin/replay: plug leaking `advance_name` variable [02/23] builtin/log: fix leaking branch name when creating cover letters [03/23] builtin/describe: fix memory leak with `--contains=` [04/23] builtin/describe: fix leaking array when running diff-index [05/23] builtin/describe: fix trivial memory leak when describing blob [06/23] builtin/name-rev: fix various trivial memory leaks [07/23] builtin/submodule--helper: fix various trivial memory leaks [08/23] builtin/ls-remote: fix leaking `pattern` strings [09/23] builtin/remote: fix leaking strings in `branch_list` [10/23] builtin/remote: fix various trivial memory leaks [11/23] builtin/stash: fix various trivial memory leaks [12/23] builtin/rev-parse: fix memory leak with `--parseopt` [13/23] builtin/show-branch: fix several memory leaks [14/23] builtin/credential-store: fix leaking credential [15/23] builtin/rerere: fix various trivial memory leaks [16/23] builtin/shortlog: fix various trivial memory leaks [17/23] builtin/worktree: fix leaking derived branch names [18/23] builtin/credential-cache: fix trivial leaks [19/23] t/test-repository: fix leaking repository [20/23] object-name: fix leaking commit list items [21/23] entry: fix leaking pathnames during delayed checkout [22/23] convert: fix leaking config strings [23/23] commit-reach: fix trivial memory leak when computing reachability

Message ID

778e87221ac1d8cc581a8c3f3572810c68686451.1721995576.git.ps@pks.im (mailing list archive)

State

Superseded

Headers

Feedback-ID: i197146af:Fastmail
Date: Fri, 26 Jul 2024 14:17:29 +0200
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Subject: [PATCH 16/23] builtin/shortlog: fix various trivial memory leaks
Message-ID: 
 <778e87221ac1d8cc581a8c3f3572810c68686451.1721995576.git.ps@pks.im>
References: <cover.1721995576.git.ps@pks.im>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LsdEeTM6MC9Zkyi0"
Content-Disposition: inline
In-Reply-To: <cover.1721995576.git.ps@pks.im>

Series

Memory leak fixes (pt.3) | expand

Commit Message

Patrick Steinhardt July 26, 2024, 12:17 p.m. UTC

There is a trivial memory leak in git-shortlog(1). Fix it.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 builtin/shortlog.c  | 1 +
 t/t4201-shortlog.sh | 1 +
 2 files changed, 2 insertions(+)

diff --git a/builtin/shortlog.c b/builtin/shortlog.c
index 5bde7c68c2..b529608c92 100644
--- a/builtin/shortlog.c
+++ b/builtin/shortlog.c
@@ -514,4 +514,5 @@  void shortlog_output(struct shortlog *log)
 	string_list_clear(&log->list, 1);
 	clear_mailmap(&log->mailmap);
 	string_list_clear(&log->format, 0);
+	string_list_clear(&log->trailers, 0);
 }
diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index f698d0c9ad..c20c885724 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -9,6 +9,7 @@  test_description='git shortlog
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'setup' '

[16/23] builtin/shortlog: fix various trivial memory leaks

Commit Message

Patch