| Message ID | 7f377c1407274aec87c6261f05bb9a944b659ba0.1570478905.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | New sparse-checkout builtin and "cone" mode | expand |
On Mon, Oct 7, 2019 at 1:08 PM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote: > > From: Derrick Stolee <dstolee@microsoft.com> > > During the development of the sparse-checkout "cone mode" feature, > an incorrect placement of the initializer for "use_cone_patterns = 1" > caused warnings to show up when a .gitignore file was present with > non-cone-mode patterns. This was fixed in the original commit > introducing the cone mode, but now we should add a test to avoid > hitting this problem again in the future. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > t/t1091-sparse-checkout-builtin.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh > index f22a4afbea..ed9355384a 100755 > --- a/t/t1091-sparse-checkout-builtin.sh > +++ b/t/t1091-sparse-checkout-builtin.sh > @@ -269,4 +269,11 @@ test_expect_success 'fail when lock is taken' ' > test_i18ngrep "File exists" err > ' > > +test_expect_success '.gitignore should not warn about cone mode' ' > + git -C repo config --worktree core.sparseCheckoutCone true && > + echo "**/bin/*" >repo/.gitignore && > + git -C repo reset --hard 2>err && > + test_i18ngrep ! "disabling cone patterns" err > +' > + > test_done > -- Makes sense; thanks for adding good preventative tests.
diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh index f22a4afbea..ed9355384a 100755 --- a/t/t1091-sparse-checkout-builtin.sh +++ b/t/t1091-sparse-checkout-builtin.sh @@ -269,4 +269,11 @@ test_expect_success 'fail when lock is taken' ' test_i18ngrep "File exists" err ' +test_expect_success '.gitignore should not warn about cone mode' ' + git -C repo config --worktree core.sparseCheckoutCone true && + echo "**/bin/*" >repo/.gitignore && + git -C repo reset --hard 2>err && + test_i18ngrep ! "disabling cone patterns" err +' + test_done