| Message ID | 8262b81141bbd36cd7a17e6abe5eb6bb688290f3.1728331771.git.code@khaugsbakk.name (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | object-name: don't allow @ as a branch name | expand |
On Mon, Oct 07, 2024 at 10:15:19PM +0200, Kristoffer Haugsbakk wrote: > Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> > --- Can we give some more details here? These are cases that already passed before your series, right? At least I'd expect the "HEAD" one to do so, but I guess the "@" fix is new? I don't need a lengthy explanation, just trying to understand how this change fits into your series. It might be simpler if this came first, adding new tests for existing behavior that was not covered, and then your 2/3 patch just adds the "@" line in the same spot. -Peff
diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh index 5ed9d7318e0..06ef54c6091 100755 --- a/t/t1402-check-ref-format.sh +++ b/t/t1402-check-ref-format.sh @@ -68,6 +68,10 @@ valid_ref 'heads/foo*/bar' --refspec-pattern valid_ref 'heads/f*o/bar' --refspec-pattern invalid_ref 'heads/f*o*/bar' --refspec-pattern invalid_ref 'heads/foo*/bar*' --refspec-pattern +invalid_ref 'HEAD' --branch +invalid_ref '@' --branch +invalid_ref '-' --branch +invalid_ref '-something' --branch ref='foo' invalid_ref "$ref"
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> --- t/t1402-check-ref-format.sh | 4 ++++ 1 file changed, 4 insertions(+)