diff mbox series

[v4,8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email

Message ID 84b1cf3f914067f8c2d056578e58d5b38bef7b45.1712878339.git.gitgitgadget@gmail.com (mailing list archive)
State Superseded
Headers show
Series docs: recommend using contrib/contacts/git-contacts | expand

Commit Message

Linus Arver April 11, 2024, 11:32 p.m. UTC
From: Linus Arver <linusa@google.com>

Signed-off-by: Linus Arver <linusa@google.com>
---
 Documentation/SubmittingPatches | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Junio C Hamano April 12, 2024, 5:19 p.m. UTC | #1
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Linus Arver <linusa@google.com>
>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
>  Documentation/SubmittingPatches | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index fd40a444f95..eac086133bc 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -420,6 +420,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed
>  work by others conflicting with your changes.  There is a good possibility
>  that these people may know the area you are touching well.
>  
> +If you are using `send-email`, you can feed it the output of `git contacts` like
> +this:
> +
> +....
> +	git send-email --cc-cmd='git contacts' feature/*.patch
> +....

Doesn't this contradict with what we said in [2/8]?

>  :current-maintainer: footnote:[The current maintainer: gitster@pobox.com]
>  :git-ml: footnote:[The mailing list: git@vger.kernel.org]
Linus Arver April 16, 2024, 12:21 a.m. UTC | #2
Junio C Hamano <gitster@pobox.com> writes:

> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Linus Arver <linusa@google.com>
>>
>> Signed-off-by: Linus Arver <linusa@google.com>
>> ---
>>  Documentation/SubmittingPatches | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
>> index fd40a444f95..eac086133bc 100644
>> --- a/Documentation/SubmittingPatches
>> +++ b/Documentation/SubmittingPatches
>> @@ -420,6 +420,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed
>>  work by others conflicting with your changes.  There is a good possibility
>>  that these people may know the area you are touching well.
>>  
>> +If you are using `send-email`, you can feed it the output of `git contacts` like
>> +this:
>> +
>> +....
>> +	git send-email --cc-cmd='git contacts' feature/*.patch
>> +....
>
> Doesn't this contradict with what we said in [2/8]?

Oops, will update.
diff mbox series

Patch

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index fd40a444f95..eac086133bc 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -420,6 +420,13 @@  trial merges of your topic to `next` and `seen`, you may have noticed
 work by others conflicting with your changes.  There is a good possibility
 that these people may know the area you are touching well.
 
+If you are using `send-email`, you can feed it the output of `git contacts` like
+this:
+
+....
+	git send-email --cc-cmd='git contacts' feature/*.patch
+....
+
 :current-maintainer: footnote:[The current maintainer: gitster@pobox.com]
 :git-ml: footnote:[The mailing list: git@vger.kernel.org]