[v5,6/9] Makefile: do not use sparse on third-party sources

Message ID	88ea94ce16c365f4b6b634a274632db134c9eba1.1723791831.git.ps@pks.im (mailing list archive)
State	Superseded
Headers	show Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBCAB12FF9C for <git@vger.kernel.org>; Fri, 16 Aug 2024 07:36:16 +0000 (UTC) Feedback-ID: i197146af:Fastmail Date: Fri, 16 Aug 2024 09:04:53 +0200 From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Cc: =?utf-8?b?UmVuw6k=?= Scharfe <l.s.r@web.de>, Junio C Hamano <gitster@pobox.com>, Kyle Lippincott <spectral@google.com>, Phillip Wood <phillip.wood@dunelm.org.uk>, Josh Steadmon <steadmon@google.com>, rsbecker@nexbridge.com, Edward Thomson <ethomson@edwardthomson.com> Subject: [PATCH v5 6/9] Makefile: do not use sparse on third-party sources Message-ID: <88ea94ce16c365f4b6b634a274632db134c9eba1.1723791831.git.ps@pks.im> References: <cover.1722415748.git.ps@pks.im> <cover.1723791831.git.ps@pks.im> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1723791831.git.ps@pks.im>
Series	Introduce clar testing framework \| expand [v5,0/9] Introduce clar testing framework [v5,1/9] t: do not pass GIT_TEST_OPTS to unit tests with prove [v5,2/9] t: import the clar unit testing framework [v5,3/9] t/clar: fix compatibility with NonStop [v5,4/9] Makefile: fix sparse dependency on GENERATED_H [v5,6/9] Makefile: do not use sparse on third-party sources [v5,7/9] Makefile: wire up the clar unit testing framework [v5,8/9] t/unit-tests: convert strvec tests to use clar [v5,9/9] t/unit-tests: convert ctype tests to use clar

Message ID

88ea94ce16c365f4b6b634a274632db134c9eba1.1723791831.git.ps@pks.im (mailing list archive)

State

Superseded

Headers

Feedback-ID: i197146af:Fastmail
Date: Fri, 16 Aug 2024 09:04:53 +0200
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: =?utf-8?b?UmVuw6k=?= Scharfe <l.s.r@web.de>,
 Junio C Hamano <gitster@pobox.com>, Kyle Lippincott <spectral@google.com>,
 Phillip Wood <phillip.wood@dunelm.org.uk>,
 Josh Steadmon <steadmon@google.com>, rsbecker@nexbridge.com,
 Edward Thomson <ethomson@edwardthomson.com>
Subject: [PATCH v5 6/9] Makefile: do not use sparse on third-party sources
Message-ID: 
 <88ea94ce16c365f4b6b634a274632db134c9eba1.1723791831.git.ps@pks.im>
References: <cover.1722415748.git.ps@pks.im>
 <cover.1723791831.git.ps@pks.im>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1723791831.git.ps@pks.im>

Series

Introduce clar testing framework | expand

Commit Message

Patrick Steinhardt Aug. 16, 2024, 7:04 a.m. UTC

We have several third-party sources in our codebase that we have
imported from upstream projects. These sources are mostly excluded from
our static analysis, for example when running Coccinelle.

Do the same for our "sparse" target by filtering them out.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5384bf8104..377ea7e144 100644
--- a/Makefile
+++ b/Makefile
@@ -3251,7 +3251,8 @@  t/helper/test-%$X: t/helper/test-%.o GIT-LDFLAGS $(GITLIBS) $(REFTABLE_TEST_LIB)
 check-sha1:: t/helper/test-tool$X
 	t/helper/test-sha1.sh
 
-SP_OBJ = $(patsubst %.o,%.sp,$(OBJECTS))
+SP_SRC = $(filter-out $(THIRD_PARTY_SOURCES),$(patsubst %.o,%.c,$(OBJECTS)))
+SP_OBJ = $(patsubst %.c,%.sp,$(SP_SRC))
 
 $(SP_OBJ): %.sp: %.c %.o $(GENERATED_H)
 	$(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \

[v5,6/9] Makefile: do not use sparse on third-party sources

Commit Message

Patch