| Message ID | 8cce69e5ba63d02ef4eb1e8cf56f47443b5bb1dd.1728906490.git.ps@pks.im (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Platform compatibility fixes | expand |
On Mon, Oct 14, 2024 at 02:21:37PM +0200, Patrick Steinhardt wrote: > When not compiling the credential cache we may use a stub function for > `cmd_credential_cache()`. With commit 9b1cb5070f (builtin: add a > repository parameter for builtin functions, 2024-09-13), we have added a > new parameter to all of those top-level `cmd_*()` functions, and did > indeed adapt the non-stubbed-out `cmd_credential_cache()`. But we didn't > adapt the stubbed-out variant, so the code does not compile. > > Fix this by adding the missing parameter. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > builtin/credential-cache.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c > index 5de8b9123bf..c51f7fc2ade 100644 > --- a/builtin/credential-cache.c > +++ b/builtin/credential-cache.c > @@ -189,7 +189,8 @@ int cmd_credential_cache(int argc, > > #else > > -int cmd_credential_cache(int argc, const char **argv, const char *prefix) > +int cmd_credential_cache(int argc, const char **argv, const char *prefix, > + struct repository *repo UNUSED) Oops. Very good catch, thanks. Thanks, Taylor
diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c index 5de8b9123bf..c51f7fc2ade 100644 --- a/builtin/credential-cache.c +++ b/builtin/credential-cache.c @@ -189,7 +189,8 @@ int cmd_credential_cache(int argc, #else -int cmd_credential_cache(int argc, const char **argv, const char *prefix) +int cmd_credential_cache(int argc, const char **argv, const char *prefix, + struct repository *repo UNUSED) { const char * const usage[] = { "git credential-cache [options] <action>",
When not compiling the credential cache we may use a stub function for `cmd_credential_cache()`. With commit 9b1cb5070f (builtin: add a repository parameter for builtin functions, 2024-09-13), we have added a new parameter to all of those top-level `cmd_*()` functions, and did indeed adapt the non-stubbed-out `cmd_credential_cache()`. But we didn't adapt the stubbed-out variant, so the code does not compile. Fix this by adding the missing parameter. Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/credential-cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)