| Message ID | 8e36d1bd1f0c8ca6b1210a537f4bb8403fab7c47.1683566870.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | docs: interpret-trailers: reword and add examples | expand |
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Linus Arver <linusa@google.com> > > The phrase "is specified" is implied. Make it explicit. Makes sense. Calling it "implied" is generous ;-) Isn't the original just outright ungrammatical? > > Signed-off-by: Linus Arver <linusa@google.com> > --- > Documentation/git-interpret-trailers.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt > index e80a9cd161b..c4675d9d3bb 100644 > --- a/Documentation/git-interpret-trailers.txt > +++ b/Documentation/git-interpret-trailers.txt > @@ -248,10 +248,10 @@ for the same <token>, 'trailer.<token>.cmd' is used and > 'trailer.<token>.command' is ignored. > > trailer.<token>.cmd:: > - This option can be used to specify a shell command that will be called: > - once to automatically add a trailer with the specified <token>, and then > - each time a '--trailer <token>=<value>' argument to modify the <value> of > - the trailer that this option would produce. > + This option can be used to specify a shell command that will be called once > + to automatically add a trailer with the specified <token>, and then called > + each time a '--trailer <token>=<value>' argument is specified to modify the > + <value> of the trailer that this option would produce. > + > When the specified command is first called to add a trailer > with the specified <token>, the behavior is as if a special
Junio C Hamano <gitster@pobox.com> writes: > "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes: >> From: Linus Arver <linusa@google.com> >> The phrase "is specified" is implied. Make it explicit. > Makes sense. Calling it "implied" is generous ;-) Haha yes, I suppose so. I wrote "implied" because supplying the (missing) phrase "is specified" was the only way I could make sense of the existing wording. > Isn't the > original just outright ungrammatical? Indeed. Should I combine 01+06 together? >> Signed-off-by: Linus Arver <linusa@google.com> >> --- >> Documentation/git-interpret-trailers.txt | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> diff --git a/Documentation/git-interpret-trailers.txt >> b/Documentation/git-interpret-trailers.txt >> index e80a9cd161b..c4675d9d3bb 100644 >> --- a/Documentation/git-interpret-trailers.txt >> +++ b/Documentation/git-interpret-trailers.txt >> @@ -248,10 +248,10 @@ for the same <token>, 'trailer.<token>.cmd' is >> used and >> 'trailer.<token>.command' is ignored. >> trailer.<token>.cmd:: >> - This option can be used to specify a shell command that will be called: >> - once to automatically add a trailer with the specified <token>, and >> then >> - each time a '--trailer <token>=<value>' argument to modify the <value> >> of >> - the trailer that this option would produce. >> + This option can be used to specify a shell command that will be called >> once >> + to automatically add a trailer with the specified <token>, and then >> called >> + each time a '--trailer <token>=<value>' argument is specified to >> modify the >> + <value> of the trailer that this option would produce. >> + >> When the specified command is first called to add a trailer >> with the specified <token>, the behavior is as if a special
Linus Arver <linusa@google.com> writes: >> Isn't the >> original just outright ungrammatical? > > Indeed. > > Should I combine 01+06 together? Either is fine. Thanks.
diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt index e80a9cd161b..c4675d9d3bb 100644 --- a/Documentation/git-interpret-trailers.txt +++ b/Documentation/git-interpret-trailers.txt @@ -248,10 +248,10 @@ for the same <token>, 'trailer.<token>.cmd' is used and 'trailer.<token>.command' is ignored. trailer.<token>.cmd:: - This option can be used to specify a shell command that will be called: - once to automatically add a trailer with the specified <token>, and then - each time a '--trailer <token>=<value>' argument to modify the <value> of - the trailer that this option would produce. + This option can be used to specify a shell command that will be called once + to automatically add a trailer with the specified <token>, and then called + each time a '--trailer <token>=<value>' argument is specified to modify the + <value> of the trailer that this option would produce. + When the specified command is first called to add a trailer with the specified <token>, the behavior is as if a special