| Message ID | 8f16c7caa7366cab22ad332c402f80823add8224.1703176866.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Minor improvements to CodingGuidelines and SubmittingPatches | expand |
"Josh Soref via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Josh Soref <jsoref@gmail.com> > > Current statistics show a strong preference to only capitalize the first > letter in a hyphenated tag, but that some guidance would be helpful: > > git log | > perl -ne 'next unless /^\s+(?:Signed-[oO]ff|Acked)-[bB]y:/; > s/^\s+//;s/:.*/:/;print'| > sort|uniq -c|sort -n > 2 Signed-off-By: > 4 Signed-Off-by: > 22 Acked-By: > 47 Signed-Off-By: > 2202 Acked-by: > 95315 Signed-off-by: > > Signed-off-by: Josh Soref <jsoref@gmail.com> > --- > Documentation/SubmittingPatches | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 31878cb70b7..4476b52a50f 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -368,6 +368,9 @@ While you can also create your own trailer if the situation warrants it, we > encourage you to instead use one of the common trailers in this project > highlighted above. > > +Extra tags should only capitalize the very first letter, i.e. favor > +"Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By". Drop "Extra", perhaps? The sentence before already discourages any extra ones, and what this sentence teaches the contributors is to avoud spelling variation when to spell the common ones. > [[git-tools]] > === Generate your patch using Git tools out of your commits.
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 31878cb70b7..4476b52a50f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -368,6 +368,9 @@ While you can also create your own trailer if the situation warrants it, we encourage you to instead use one of the common trailers in this project highlighted above. +Extra tags should only capitalize the very first letter, i.e. favor +"Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By". + [[git-tools]] === Generate your patch using Git tools out of your commits.