diff mbox series

[v2,2/3] line-log: remove output_prefix()

Message ID 94d2c034b4a82ca1024b2a591aef990688f95862.1727956724.git.gitgitgadget@gmail.com (mailing list archive)
State Accepted
Commit 8aeff2c287aea1a8673d78574a5709510a789640
Headers show
Series line-log: protect inner strbuf from free | expand

Commit Message

Jeff King Oct. 3, 2024, 11:58 a.m. UTC 
From: Jeff King <peff@peff.net>

Now that output_prefix() returns a const char * type, it matches the
behavior of diff_line_prefix() and no longer needs to exist on its own.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Derrick Stolee <stolee@gmail.com>
---
 line-log.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
diff mbox series

Patch

diff --git a/line-log.c b/line-log.c
index 29cf66bdd10..63945c47299 100644
--- a/line-log.c
+++ b/line-log.c
@@ -897,16 +897,6 @@  static void print_line(const char *prefix, char first,
 		fputs("\\ No newline at end of file\n", file);
 }
 
-static const char *output_prefix(struct diff_options *opt)
-{
-	if (opt->output_prefix) {
-		struct strbuf *sb = opt->output_prefix(opt, opt->output_prefix_data);
-		return sb->buf;
-	} else {
-		return "";
-	}
-}
-
 static void dump_diff_hacky_one(struct rev_info *rev, struct line_log_data *range)
 {
 	unsigned int i, j = 0;
@@ -916,7 +906,7 @@  static void dump_diff_hacky_one(struct rev_info *rev, struct line_log_data *rang
 	struct diff_ranges *diff = &range->diff;
 
 	struct diff_options *opt = &rev->diffopt;
-	const char *prefix = output_prefix(opt);
+	const char *prefix = diff_line_prefix(opt);
 	const char *c_reset = diff_get_color(opt->use_color, DIFF_RESET);
 	const char *c_frag = diff_get_color(opt->use_color, DIFF_FRAGINFO);
 	const char *c_meta = diff_get_color(opt->use_color, DIFF_METAINFO);
@@ -1011,7 +1001,7 @@  out:
  */
 static void dump_diff_hacky(struct rev_info *rev, struct line_log_data *range)
 {
-	const char *prefix = output_prefix(&rev->diffopt);
+	const char *prefix = diff_line_prefix(&rev->diffopt);
 
 	fprintf(rev->diffopt.file, "%s\n", prefix);