diff mbox series

[v2,4/4] doc: refer to internet archive

Message ID 9f0bba69492b345fe7b0c7f9529b025ed98c7e29.1695553043.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series Switch links to https | expand

Commit Message

Josh Soref Sept. 24, 2023, 10:57 a.m. UTC 
From: Josh Soref <jsoref@gmail.com>

These pages are no longer reachable from their original locations,
which makes things difficult for readers. Instead, switch to linking to
the Internet Archive for the content.

Signed-off-by: Josh Soref <jsoref@gmail.com>
---
 gitweb/gitweb.perl       | 4 ++--
 sha1dc/sha1.c            | 2 +-
 t/lib-gpg.sh             | 2 +-
 t/t9816-git-p4-locked.sh | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

Comments

Elijah Newren Nov. 23, 2023, 9:33 p.m. UTC | #1 
On Sun, Sep 24, 2023 at 2:47 PM Josh Soref via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Josh Soref <jsoref@gmail.com>
>
> These pages are no longer reachable from their original locations,
> which makes things difficult for readers. Instead, switch to linking to
> the Internet Archive for the content.

Thanks, these all look good, except on of the old links works for me.
Maybe it was just down the day you checked?  More comments on that
below...

>
> Signed-off-by: Josh Soref <jsoref@gmail.com>
> ---
>  gitweb/gitweb.perl       | 4 ++--
>  sha1dc/sha1.c            | 2 +-
>  t/lib-gpg.sh             | 2 +-
>  t/t9816-git-p4-locked.sh | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index b6659410ef1..f12bed87db9 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8192,8 +8192,8 @@ sub git_feed {
>         my $format = shift || 'atom';
>         my $have_blame = gitweb_check_feature('blame');
>
> -       # Atom: http://www.atomenabled.org/developers/syndication/
> -       # RSS:  http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
> +       # Atom: https://web.archive.org/web/20230815171113/https://www.atomenabled.org/developers/syndication/
> +       # RSS:  https://web.archive.org/web/20030729001534/http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ

The original www.atomenabled.org link works for me.
Josh Soref Nov. 24, 2023, 3:24 a.m. UTC | #2 
Elijah Newren wrote:
> Thanks, these all look good, except on of the old links works for me.
> Maybe it was just down the day you checked?

> More comments on that below...

> > -       # Atom: http://www.atomenabled.org/developers/syndication/
> > -       # RSS:  http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
> > +       # Atom: https://web.archive.org/web/20230815171113/https://www.atomenabled.org/developers/syndication/
> > +       # RSS:  https://web.archive.org/web/20030729001534/http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
>
> The original www.atomenabled.org link works for me.

That's odd. As you can see based on my archive.org link, at some point
they had `https` support (their certificate expired Feb 7, 2021 UTC).

Personally, as a former web browser developer, I'd rather people rely
on archived authenticated content than content that could be rewritten
in transit.

That said, I'm going to drop this change.
Elijah Newren Nov. 24, 2023, 3:32 p.m. UTC | #3 
On Thu, Nov 23, 2023 at 7:24 PM Josh Soref <jsoref@gmail.com> wrote:
>
> Elijah Newren wrote:
> > Thanks, these all look good, except on of the old links works for me.
> > Maybe it was just down the day you checked?
>
> > More comments on that below...
>
> > > -       # Atom: http://www.atomenabled.org/developers/syndication/
> > > -       # RSS:  http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
> > > +       # Atom: https://web.archive.org/web/20230815171113/https://www.atomenabled.org/developers/syndication/
> > > +       # RSS:  https://web.archive.org/web/20030729001534/http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
> >
> > The original www.atomenabled.org link works for me.
>
> That's odd. As you can see based on my archive.org link, at some point
> they had `https` support (their certificate expired Feb 7, 2021 UTC).
>
> Personally, as a former web browser developer, I'd rather people rely
> on archived authenticated content than content that could be rewritten
> in transit.

I think that'd be perfectly reasonable, I was just thrown because the
justification was that the links no longer worked.  Mentioning why the
changes are being made in the commit message, and in particular that
there are two reasons for the changes, would have been sufficient.

> That said, I'm going to drop this change.

Your call.
diff mbox series

Patch

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b6659410ef1..f12bed87db9 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -8192,8 +8192,8 @@  sub git_feed {
 	my $format = shift || 'atom';
 	my $have_blame = gitweb_check_feature('blame');
 
-	# Atom: http://www.atomenabled.org/developers/syndication/
-	# RSS:  http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
+	# Atom: https://web.archive.org/web/20230815171113/https://www.atomenabled.org/developers/syndication/
+	# RSS:  https://web.archive.org/web/20030729001534/http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ
 	if ($format ne 'rss' && $format ne 'atom') {
 		die_error(400, "Unknown web feed format");
 	}
diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c
index dede2cbddf9..f993ef9c690 100644
--- a/sha1dc/sha1.c
+++ b/sha1dc/sha1.c
@@ -88,7 +88,7 @@ 
 /*
  * Should define Big Endian for a whitelist of known processors. See
  * https://sourceforge.net/p/predef/wiki/Endianness/ and
- * http://www.oracle.com/technetwork/server-storage/solaris/portingtosolaris-138514.html
+ * https://web.archive.org/web/20140421151132/http://www.perforce.com/perforce/doc.current/manuals/p4sag/chapter.superuser.html
  */
 #define SHA1DC_BIGENDIAN
 
diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index 83b83c9abb5..add11e88fc0 100644
--- a/t/lib-gpg.sh
+++ b/t/lib-gpg.sh
@@ -13,7 +13,7 @@  test_lazy_prereq GPG '
 	gpg_version=$(gpg --version 2>&1)
 	test $? != 127 || exit 1
 
-	# As said here: http://www.gnupg.org/documentation/faqs.html#q6.19
+	# As said here: https://web.archive.org/web/20130212022238/https://www.gnupg.org/faq/gnupg-faq.html#why-does-gnupg-1.0.6-bail-out-on-keyrings-used-with-1.0.7
 	# the gpg version 1.0.6 did not parse trust packets correctly, so for
 	# that version, creation of signed tags using the generated key fails.
 	case "$gpg_version" in
diff --git a/t/t9816-git-p4-locked.sh b/t/t9816-git-p4-locked.sh
index 932841003cf..5e904ac80d8 100755
--- a/t/t9816-git-p4-locked.sh
+++ b/t/t9816-git-p4-locked.sh
@@ -9,7 +9,7 @@  test_expect_success 'start p4d' '
 '
 
 # See
-# http://www.perforce.com/perforce/doc.current/manuals/p4sag/03_superuser.html#1088563
+# https://web.archive.org/web/20150602090517/http://www.perforce.com/perforce/doc.current/manuals/p4sag/chapter.superuser.html#superuser.basic.typemap_locking
 # for suggestions on how to configure "sitewide pessimistic locking"
 # where only one person can have a file open for edit at a time.
 test_expect_success 'init depot' '