No edit option when "git add --patch" a new file

Commit Message

Yuchen Ying Sept. 8, 2020, 4:16 p.m. UTC

Hi list,

I was attempting to "add --patch" a newly created file but the "edit"
option is not provided.

Steps to reproduce this problem:

$ echo "test\ntest" > test
$ git add -N test
$ git add -p test

Expected: e is an option
Got:

$ git add -p
+++ b/terraform/test
new file mode 100644
@@ -0,0 +1,2 @@
+asdf
+asdf
(1/1) Stage addition [y,n,q,a,d,?]? e
Sorry, cannot edit this hunk

Comments

Phillip Wood Sept. 9, 2020, 9:33 a.m. UTC | #1

On 08/09/2020 17:16, Yuchen Ying wrote:
> Hi list,
> 
> I was attempting to "add --patch" a newly created file but the "edit"
> option is not provided.
> 
> Steps to reproduce this problem:
> 
> $ echo "test\ntest" > test
> $ git add -N test
> $ git add -p test
> 
> Expected: e is an option
> Got:
> 
> $ git add -p
> diff --git a/terraform/test b/terraform/test
> index 0000000..992533b
> --- /dev/null
> +++ b/terraform/test
> new file mode 100644
> @@ -0,0 +1,2 @@
> +asdf
> +asdf
> (1/1) Stage addition [y,n,q,a,d,?]? e
> Sorry, cannot edit this hunk

Thanks for taking the time to report this issue. I'm currently working
on a fix which I hope to post later today as the issue was previously
reported at
https://public-inbox.org/git/[e-mail]/
I'll Cc you on the patch

Best Wishes

Phillip

Patch

diff --git a/terraform/test b/terraform/test
index 0000000..992533b
--- /dev/null