[GSoC,Newbie] Test Script Enhancements

Commit Message

Rhythm-26 Jan. 5, 2025, 9:39 a.m. UTC

Hi Everyone,
My name is Rhythm Narula and I am currently working as a Software
Engineer. I had the privilege of participating in GSoC 2023 with
Pitivi, GNOME, where I completed a project on generating closing
credit clips. LinkedIn -
https://www.linkedin.com/in/rhythm-narula-34b652191/

As someone who uses Git daily for version control and collaboration, I
have developed a strong interest in understanding its internals and
contributing to its improvement, allowing me to impact millions of
developers worldwide.

I understand that GSoC 2025 mini project ideas have not yet been
released, however, I have been exploring 2024 mini project ideas and
noticed a few areas where improvements might still be possible. I have
outlined these below and world appreciate your feedback on whether
these are accurate and worth pursuing:

1. Avoid suppressing git’s exit code in test scripts
a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
index d21877150e..3433fcfc44 100755

2. Modernize a test script
Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?

Regards,
Rhythm

Comments

Eric Sunshine Jan. 5, 2025, 9:51 a.m. UTC | #1

On Sun, Jan 5, 2025 at 4:39 AM Rhythm Narula <[e-mail]> wrote:
> 1. Avoid suppressing git’s exit code in test scripts
> a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> @@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '
>  clean_mark () {
>         cut -f 2 -d ' ' "$1" |
> -       git cat-file --batch-check |
> +       git cat-file --batch-check >actual &&
>         grep commit |
>         sort >$(basename "$1")
>  }

At a quick glance, I'd say that this change is incomplete and won't
work as you expect.

> 2. Modernize a test script
> Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?

No need to ask before working on something in Git. You're free to pick
any modernization. A good way to check if anyone is touching this
particular script is to search the mail archive[*] for recent mentions
of "t5801".

[*]: https://lore.kernel.org/git/

Patch

--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@ -271,7 +271,7 @@  test_expect_success 'push update refs failure' '

 clean_mark () {
        cut -f 2 -d ' ' "$1" |
-       git cat-file --batch-check |
+       git cat-file --batch-check >actual &&
        grep commit |
        sort >$(basename "$1")
 }