| Message ID | X85+TEQusPhTUmSj@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3361390cbedc962adcddcfd98676695c125fa180 |
| Headers | show |
| Series | misc commit-graph and oid-array cleanups | expand |
diff --git a/commit-graph.c b/commit-graph.c index 4a718fd6e6..06f8dc1d89 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -932,8 +932,8 @@ struct tree *get_commit_tree_in_graph(struct repository *r, const struct commit struct packed_commit_list { struct commit **list; - int nr; - int alloc; + size_t nr; + size_t alloc; }; struct write_commit_graph_context {
Our packed_commit_list is an array of pointers to commit structs. We use "int" for the allocation, which is 32-bit even on 64-bit platforms. This isn't likely to overflow in practice (we're writing commit graphs, so you'd need to actually have billions of unique commits in the repository). But it's good practice to use size_t for allocations. Signed-off-by: Jeff King <peff@peff.net> --- commit-graph.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)