| Message ID | Y/hba4Zq/j4ZhFoM@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77ef8b0e1e9e9e70aa8756b45ed12a190a3bcc91 |
| Headers | show |
| Series | more -Wunused-parameter fixes | expand |
diff --git a/http-backend.c b/http-backend.c index 8ab58e55f8..fc3ab97c0f 100644 --- a/http-backend.c +++ b/http-backend.c @@ -736,7 +736,7 @@ static int bad_request(struct strbuf *hdr, const struct service_cmd *c) return 0; } -int cmd_main(int argc, const char **argv) +int cmd_main(int argc UNUSED, const char **argv UNUSED) { char *method = getenv("REQUEST_METHOD"); const char *proto_header;
We can't drop them because it's cmd_main(), which has a set prototype, but the CGI interface does not do anything with such arguments. Arguably we could detect them and complain. It's possible this could detect misconfigurations or other mistakes, but: - as far as I can tell common webservers like apache do not have any mechanism to pass arguments to a CGI at all, so this isn't a mistake one could even make - it's possible that some obscure webserver might pass arguments, and we'd break that case. I have no idea if such a webserver exists; the CGI standard says only "The script is invoked in a system-defined manner". So probably it would not hurt to detect them, but it also is unlikely to help anyone. Let's just mark them as unused, which retains the current behavior but silences -Wunused-parameter. Signed-off-by: Jeff King <peff@peff.net> --- http-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)