| Message ID | ZAMeExFKTULOFZF1@coredump.intra.peff.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0bbe10313e0b61812082d47431e8648f9df48f15 |
| Headers | show |
| Series | handling "-" as stdin/stdout in git bundle | expand |
diff --git a/parse-options.c b/parse-options.c index 25bae8b585b..6dd4c090e03 100644 --- a/parse-options.c +++ b/parse-options.c @@ -63,10 +63,8 @@ static void fix_filename(const char *prefix, char **file) { if (!file || !*file) ; /* leave as NULL */ - else if (!strcmp("-", *file)) - *file = xstrdup(*file); else - *file = prefix_filename(prefix, *file); + *file = prefix_filename_except_for_dash(prefix, *file); } static enum parse_opt_result opt_command_mode_error(
Since our fix_filename()'s only remaining special case is handling "-", we can use the newly-minted helper function that handles this already. Signed-off-by: Jeff King <peff@peff.net> --- If we do eventually find that "!file || !*file" is a sign of a bug, we could perhaps just simplify this whole function away. :) parse-options.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)