| Message ID | a65d235dd3c14df4945b9753507d9cdab777966c.1698305961.git.ps@pks.im (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ci: add GitLab CI definition | expand |
On Thu, Oct 26, 2023 at 10:00:12AM +0200, Patrick Steinhardt wrote: >Pull in "lib.sh" into "install-docker-dependencies.sh" such that we can >set up proper groups for those dependencise. This allows the reader to ^^ !!! >collapse sections in the CI output on GitHub Actions (and later on on >GitLab CI). > the structure of the text is kind of backwards - the fact that you need to pull in a lib is just a consequence, not the intent, which imo should come first. tough it mostly doesn't matter, as it's just one short paragraph. regards
On Thu, Oct 26, 2023 at 10:34:10AM +0200, Oswald Buddenhagen wrote: > On Thu, Oct 26, 2023 at 10:00:12AM +0200, Patrick Steinhardt wrote: > > Pull in "lib.sh" into "install-docker-dependencies.sh" such that we can > > set up proper groups for those dependencise. This allows the reader to > ^^ !!! > > collapse sections in the CI output on GitHub Actions (and later on on > > GitLab CI). > > > the structure of the text is kind of backwards - the fact that you need to > pull in a lib is just a consequence, not the intent, which imo should come > first. tough it mostly doesn't matter, as it's just one short paragraph. > > regards Good point indeed. Will rewrite. Patrick
diff --git a/ci/install-docker-dependencies.sh b/ci/install-docker-dependencies.sh index 78b7e326da6..d0bc19d3bb3 100755 --- a/ci/install-docker-dependencies.sh +++ b/ci/install-docker-dependencies.sh @@ -3,6 +3,10 @@ # Install dependencies required to build and test Git inside container # +. ${0%/*}/lib.sh + +begin_group "Install dependencies" + case "$jobname" in linux32) linux32 --32bit i386 sh -c ' @@ -20,3 +24,5 @@ pedantic) dnf -yq install make gcc findutils diffutils perl python3 gettext zlib-devel expat-devel openssl-devel curl-devel pcre2-devel >/dev/null ;; esac + +end_group "Install dependencies"
Pull in "lib.sh" into "install-docker-dependencies.sh" such that we can set up proper groups for those dependencise. This allows the reader to collapse sections in the CI output on GitHub Actions (and later on on GitLab CI). Signed-off-by: Patrick Steinhardt <ps@pks.im> --- ci/install-docker-dependencies.sh | 6 ++++++ 1 file changed, 6 insertions(+)