diff mbox series

[v14,2/2] win32: close handles of threads that have been joined

Message ID aa0319bc08e5b05f291fb2b1e9e1b20734f512bf.1672933474.git.gitgitgadget@gmail.com (mailing list archive)
State Accepted
Commit 238a9dfe86d18214bc0b8be079feee01a2fdc407
Headers show
Series win32: close handles of threads that have been joined | expand

Commit Message

Seija Kijin Jan. 5, 2023, 3:44 p.m. UTC 
From: Seija Kijin <doremylover123@gmail.com>

After the thread terminates, the handle to the
original thread should be closed.

This change makes win32_pthread_join POSIX compliant.

Signed-off-by: Seija Kijin <doremylover123@gmail.com>
---
 compat/win32/pthread.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/compat/win32/pthread.c b/compat/win32/pthread.c
index cf53bc61d82..85f8f7920ce 100644
--- a/compat/win32/pthread.c
+++ b/compat/win32/pthread.c
@@ -42,10 +42,13 @@  int win32_pthread_join(pthread_t *thread, void **value_ptr)
 	case WAIT_OBJECT_0:
 		if (value_ptr)
 			*value_ptr = thread->arg;
+		CloseHandle(thread->handle);
 		return 0;
 	case WAIT_ABANDONED:
+		CloseHandle(thread->handle);
 		return EINVAL;
 	default:
+		/* the wait failed, so do not detach */
 		return err_win_to_posix(GetLastError());
 	}
 }