diff mbox series

[1/2] commit-graph: when closing the graph, also release the slab

Message ID aade3ca574063a73d849a0081e4653a7f30eda78.1631089771.git.gitgitgadget@gmail.com (mailing list archive)
State Accepted
Commit 957ba814bf93b698742ffa3cf37e4f665ed95b45
Headers show
Series pull: release handles to pack files before potentially gc'ing | expand

Commit Message

Johannes Schindelin Sept. 8, 2021, 8:29 a.m. UTC 
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The slab has information about the commit graph. That means that it is
meaningless (and even misleading) when the commit graph was closed.

This seems not to matter currently, but we're about to fix a
Windows-specific bug where `git pull` does not close the object store
before fetching (risking that an implicit auto-gc fails to remove the
now-obsolete pack file(s)), and once we have that bug fix in place, it
does matter: after that bug fix, we will open the object store, do some
stuff with it, then close it, fetch, and then open it again, and do more
stuff. If we close the commit graph without releasing the corresponding
slab, we're hit by a symptom like this in t5520.19:

	BUG: commit-reach.c:85: bad generation skip 9223372036854775807
	> 3 at 5cd378271655d43a3b4477520014f02213ad1546

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 commit-graph.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/commit-graph.c b/commit-graph.c
index 3860a0d8477..09984455150 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -713,6 +713,7 @@  static void close_commit_graph_one(struct commit_graph *g)
 	if (!g)
 		return;
 
+	clear_commit_graph_data_slab(&commit_graph_data_slab);
 	close_commit_graph_one(g->base_graph);
 	free_commit_graph(g);
 }