| Message ID | ad3f23a9f0c2c92ac95406fcadc51eec1a9861ff.1655336146.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 41a86b64c093a6f36ffe0959aeed2e3f2590c7e8 |
| Headers | show |
| Series | Coverity fixes | expand |
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > In c51f8f94e5b3 (submodule--helper: run update procedures from C, > 2021-08-24), we added code that first obtains the default remote, and > then adds that to a `strvec`. > > However, we never released the default remote's memory. > > Reported by Coverity. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > builtin/submodule--helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index d7b8004b933..9a8248ffe6a 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -2208,6 +2208,7 @@ static int fetch_in_submodule(const char *module_path, int depth, int quiet, str > char *hex = oid_to_hex(oid); > char *remote = get_default_remote(); > strvec_pushl(&cp.args, remote, hex, NULL); > + free(remote); Trivially correct. Will queue. > } > > return run_command(&cp);
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index d7b8004b933..9a8248ffe6a 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -2208,6 +2208,7 @@ static int fetch_in_submodule(const char *module_path, int depth, int quiet, str char *hex = oid_to_hex(oid); char *remote = get_default_remote(); strvec_pushl(&cp.args, remote, hex, NULL); + free(remote); } return run_command(&cp);