From patchwork Mon Apr 19 11:46:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 12211649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB78C433ED for ; Mon, 19 Apr 2021 11:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57E6361090 for ; Mon, 19 Apr 2021 11:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238751AbhDSLrO (ORCPT ); Mon, 19 Apr 2021 07:47:14 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:39387 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238856AbhDSLrJ (ORCPT ); Mon, 19 Apr 2021 07:47:09 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A8505B01; Mon, 19 Apr 2021 07:46:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 19 Apr 2021 07:46:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=K4JgZnJdYfycPHrP9xfCggxiDsh 7q22Nb6DqqR/ypmA=; b=nqlR5KcRcFvE2H0O5hXlQ17J0Z0KQ2S0HxYWFIl/rAA 8D+QXVlSrD0hie0j7Mp2nvuvNQ5YBS1/iaSFHX4ofUnUlzOB+r/z1oF6Esyh1XdD glRO5QH6diETHPMAx0WODW6vRHTKtUwMtvI2/E22VA+rTAIOvA8S2OSpFGfHWJmq ZsgYqWLe2AntPAxFxNdLSUmsWvqeOwXpm4yQLKzQg+d+RxA/jLdT5JlQtTPGwvPP ZvLrXUvq8wlnmciSiTTHPSU5i49iREWP7eRVe81aRdEpo94CqVb4+IL2gXu2Xi78 WwtCfgLdoNQGL1nxdiBz4qsQhHg5Vn5TcOwF2BoaL9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=K4JgZn JdYfycPHrP9xfCggxiDsh7q22Nb6DqqR/ypmA=; b=Ad6eqbep6gkyi8zDYJO/xJ hFb5Av0s0HD4cd3wlgpnNIZnixX5uA0de2tDAzsC/pdPtfT/HJ0IVxLPBY6Aljj2 W4x7UpJKWH89LXXP6PFw56b+OjavXamVPqHtbv4QJbTYW8tTurjaFV8zj20g9hY+ 7NBQqpsZustTg+SQOmP9ivbLCtXpmGRaM7I+GOrhvyy9oJxuOc60ifJ+B2Nlb2/Q yh3toQn6GHMqJFokvANMSiXa+b9EbcM08abUbz1idGULN+6ybt7jjrLwEDo5kTnN Bn6E3kS/IhfupEkJRpVf+9hQe+Yol10KEjtLejGbQnQ8z5Kvw3vPrynrmGVkg7cQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtgedggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeejrdduledurdeikedrkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4dbf4450.dyn.telefonica.de [77.191.68.80]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E213108006B; Mon, 19 Apr 2021 07:46:38 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 7887ba6d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 19 Apr 2021 11:46:37 +0000 (UTC) Date: Mon, 19 Apr 2021 13:46:36 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Jeff King , Christian Couder , Taylor Blau , Philip Oakley , Ramsay Jones , =?iso-8859-1?q?=C6var_Arnfj=F6r?= =?iso-8859-1?q?=F0?= Bjarmason Subject: [PATCH v5 1/8] uploadpack.txt: document implication of `uploadpackfilter.allow` Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org When `uploadpackfilter.allow` is set to `true`, it means that filters are enabled by default except in the case where a filter is explicitly disabled via `uploadpackilter..allow`. This option will not only enable the currently supported set of filters, but also any filters which get added in the future. As such, an admin which wants to have tight control over which filters are allowed and which aren't probably shouldn't ever set `uploadpackfilter.allow=true`. Amend the documentation to make the ramifications more explicit so that admins are aware of this. Signed-off-by: Patrick Steinhardt --- Documentation/config/uploadpack.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt index b0d761282c..6729a072ea 100644 --- a/Documentation/config/uploadpack.txt +++ b/Documentation/config/uploadpack.txt @@ -59,7 +59,8 @@ uploadpack.allowFilter:: uploadpackfilter.allow:: Provides a default value for unspecified object filters (see: the - below configuration variable). + below configuration variable). If set to `true`, this will also + enable all filters which get added in the future. Defaults to `true`. uploadpackfilter..allow::