From patchwork Thu Apr 2 07:09:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11470189 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6442C2D34 for ; Thu, 2 Apr 2020 07:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 425D820784 for ; Thu, 2 Apr 2020 07:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="NiYz5upb"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="zzsfl8/v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387509AbgDBHJk (ORCPT ); Thu, 2 Apr 2020 03:09:40 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:55501 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387447AbgDBHJj (ORCPT ); Thu, 2 Apr 2020 03:09:39 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C57EE5C0293; Thu, 2 Apr 2020 03:09:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 02 Apr 2020 03:09:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=c/r194pnijwD639zp9GRammRLa+ motWVbhfHPCgM2EY=; b=NiYz5upbxutOmG9vkfQz1Os1LYoKxnzIsTBqjvqU+Ky Uat207hHHtWzwUX4AYSd7ivbhcMt1hF278WIK3DM280502+CfGjXTKlXQXtVClWD tQnhOfF7YI0B+aSK36KzvsckT3SWZaWYUn8WBmzQjp0fgnekLu8x4mWXs5hkYDF0 n9J+cgXAFSWb2EID3a3tqLoQ31iKZdJs4K5yj1vhcM6tWeALLP6bFPsv2TFZi+s0 JDBV5FoklwHisfnsrQJLRsUnK+bhhopKwPH4VAWXMnKFFddRKlgZEssZGSy5CM7+ crQO+TIEnTpQoOFRhstlxkyfDArqBPuwzNf0TNgsh2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=c/r194 pnijwD639zp9GRammRLa+motWVbhfHPCgM2EY=; b=zzsfl8/vk180U/MHeQAzuQ bIB6nk276R3Bcb5YP6n0RHh7njytAEVlC+V3jYqs9vLxyP6210gK1BHnP3D6wAYE cfellz1WAfrC1u3C3S3RuunExh86SZ3rUjaM2ztBXbeAQ+iYFwA9YHPDuqeI/kz0 Bls9r5Td0Szt/ejhFg2TZlyuF+vDGVZQ+sJoUaF1KtXDzNC863YqX6XvbVunBLgO NNVofrEw1Tm8Fdh4O8Z08rvM+Zq8ppJFTxEeyXmMY1MZVyOwbSxMqXgHS5vIpWu6 iEymebA9YPiAgQOjIX2yJ9AgyDOBAkNh/mZqMh6chrHOjoXgKoSLi+0U5zxa4blg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdefgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepkeelrdduvd drleegrddvkeenucevlhhushhtvghrufhiiigvpeehnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x590c5e1c.dyn.telefonica.de [89.12.94.28]) by mail.messagingengine.com (Postfix) with ESMTPA id 3167A306CD98; Thu, 2 Apr 2020 03:09:38 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id cff692a1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Apr 2020 07:09:36 +0000 (UTC) Date: Thu, 2 Apr 2020 09:09:43 +0200 From: Patrick Steinhardt To: git Cc: Christian Couder , Junio C Hamano Subject: [PATCH v3 5/9] update-ref: drop unused argument for `parse_refname` Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The `parse_refname` function accepts a `struct strbuf *input` argument that isn't used at all. As we're about to convert commands to not use a strbuf anymore but instead an end pointer, let's drop this argument now to make the converting commit easier to review. Signed-off-by: Patrick Steinhardt --- builtin/update-ref.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/update-ref.c b/builtin/update-ref.c index a6ff88b95b..1bba5ea6c2 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -50,7 +50,7 @@ static const char *parse_arg(const char *next, struct strbuf *arg) * the argument. Die if C-quoting is malformed or the reference name * is invalid. */ -static char *parse_refname(struct strbuf *input, const char **next) +static char *parse_refname(const char **next) { struct strbuf ref = STRBUF_INIT; @@ -186,7 +186,7 @@ static const char *parse_cmd_update(struct ref_transaction *transaction, struct object_id new_oid, old_oid; int have_old; - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("update: missing "); @@ -220,7 +220,7 @@ static const char *parse_cmd_create(struct ref_transaction *transaction, char *refname; struct object_id new_oid; - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("create: missing "); @@ -253,7 +253,7 @@ static const char *parse_cmd_delete(struct ref_transaction *transaction, struct object_id old_oid; int have_old; - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("delete: missing "); @@ -288,7 +288,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction, char *refname; struct object_id old_oid; - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("verify: missing ");