diff mbox series

[v2,01/12] t3210: move to t0601

Message ID ca65b9e6122d10a7b43d06a6069dae00e645a392.1705695540.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series Group reffiles tests | expand

Commit Message

John Cai Jan. 19, 2024, 8:18 p.m. UTC
From: John Cai <johncai86@gmail.com>

Move t3210 to t0601, since these tests are reffiles specific in that
they modify loose refs manually. This is part of the effort to
categorize these tests together based on the ref backend they test. When
we upstream the reftable backend, we can add more tests to t06xx. This
way, all tests that test specific ref backend behavior will be grouped
together.

Signed-off-by: John Cai <johncai86@gmail.com>
---
 t/{t3210-pack-refs.sh => t0601-reffiles-pack-refs.sh} | 6 ++++++
 1 file changed, 6 insertions(+)
 rename t/{t3210-pack-refs.sh => t0601-reffiles-pack-refs.sh} (98%)

Comments

Patrick Steinhardt Jan. 22, 2024, 11:31 a.m. UTC | #1
On Fri, Jan 19, 2024 at 08:18:49PM +0000, John Cai via GitGitGadget wrote:
> From: John Cai <johncai86@gmail.com>
> 
> Move t3210 to t0601, since these tests are reffiles specific in that
> they modify loose refs manually. This is part of the effort to
> categorize these tests together based on the ref backend they test. When
> we upstream the reftable backend, we can add more tests to t06xx. This
> way, all tests that test specific ref backend behavior will be grouped
> together.
> 
> Signed-off-by: John Cai <johncai86@gmail.com>
> ---
>  t/{t3210-pack-refs.sh => t0601-reffiles-pack-refs.sh} | 6 ++++++
>  1 file changed, 6 insertions(+)
>  rename t/{t3210-pack-refs.sh => t0601-reffiles-pack-refs.sh} (98%)
> 
> diff --git a/t/t3210-pack-refs.sh b/t/t0601-reffiles-pack-refs.sh
> similarity index 98%
> rename from t/t3210-pack-refs.sh
> rename to t/t0601-reffiles-pack-refs.sh
> index 7f4e98db7db..f7a3f693901 100755
> --- a/t/t3210-pack-refs.sh
> +++ b/t/t0601-reffiles-pack-refs.sh
> @@ -15,6 +15,12 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>  TEST_PASSES_SANITIZE_LEAK=true
>  . ./test-lib.sh
>  
> +if ! test_have_prereq REFFILES
> +	then
> +		skip_all='skipping reffiles specific tests'
> +		test_done
> +fi

Indentation here is off as we do not typically ident the `then`. So this
should rather look like the following:

if ! test_have_prereq REFFILES
then
	skip_all='skipping reffiles specific tests'
	test_done
fi

Patrick
diff mbox series

Patch

diff --git a/t/t3210-pack-refs.sh b/t/t0601-reffiles-pack-refs.sh
similarity index 98%
rename from t/t3210-pack-refs.sh
rename to t/t0601-reffiles-pack-refs.sh
index 7f4e98db7db..f7a3f693901 100755
--- a/t/t3210-pack-refs.sh
+++ b/t/t0601-reffiles-pack-refs.sh
@@ -15,6 +15,12 @@  export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
+if ! test_have_prereq REFFILES
+	then
+		skip_all='skipping reffiles specific tests'
+		test_done
+fi
+
 test_expect_success 'enable reflogs' '
 	git config core.logallrefupdates true
 '