diff mbox series

[v2,5/5] completion: reflog subcommands and options

Message ID cf3933b2-a577-4df1-9425-cf324f03d6da@gmail.com (mailing list archive)
State Accepted
Commit 1284f9cc11be4b656492938f68befbe4c87d915f
Headers show
Series completion for git-reflog show | expand

Commit Message

Rubén Justo March 2, 2024, 3:52 p.m. UTC 
Make generic the completion for reflog subcommands and its options.

Note that we still need to special case the options for "show".

Signed-off-by: Rubén Justo <rjusto@gmail.com>
---
 contrib/completion/git-completion.bash | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index f9fbf1f703..c5c9e9de2d 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2445,8 +2445,12 @@  _git_rebase ()
 
 _git_reflog ()
 {
-	local subcommands="show delete expire"
-	local subcommand="$(__git_find_subcommand "$subcommands" "show")"
+	local subcommands subcommand
+
+	__git_resolve_builtins "reflog"
+
+	subcommands="$___git_resolved_builtins"
+	subcommand="$(__git_find_subcommand "$subcommands" "show")"
 
 	case "$subcommand,$cur" in
 	show,--*)
@@ -2455,6 +2459,10 @@  _git_reflog ()
 			"
 		return
 		;;
+	$subcommand,--*)
+		__gitcomp_builtin "reflog_$subcommand"
+		return
+		;;
 	esac
 
 	__git_complete_refs