[09/27] t4015: use test_write_lines()

Message ID	d27bc8bad35aaecaa1f73045f8247c9e5fe053aa.1573779465.git.liu.denton@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=V4lN=ZH=vger.kernel.org=git-owner@kernel.org> Date: Thu, 14 Nov 2019 17:00:53 -0800 From: Denton Liu <liu.denton@gmail.com> To: Git Mailing List <git@vger.kernel.org> Subject: [PATCH 09/27] t4015: use test_write_lines() Message-ID: <d27bc8bad35aaecaa1f73045f8247c9e5fe053aa.1573779465.git.liu.denton@gmail.com> References: <cover.1573779465.git.liu.denton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1573779465.git.liu.denton@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: git-owner@vger.kernel.org Precedence: bulk
Series	t: general test cleanup + `set -o pipefail` \| expand [00/27] t: general test cleanup + `set -o pipefail` [01/27] lib-bash.sh: move `then` onto its own line [02/27] t0014: remove git command upstream of pipe [03/27] t0090: stop losing return codes of git commands [04/27] t3301: stop losing return codes of git commands [05/27] t3600: use test_line_count() where possible [06/27] t3600: stop losing return codes of git commands [07/27] t3600: comment on inducing SIGPIPE in `git rm` [08/27] t4015: stop losing return codes of git commands [09/27] t4015: use test_write_lines() [10/27] t4138: stop losing return codes of git commands [11/27] t5317: stop losing return codes of git commands [12/27] t5317: use ! grep to check for no matching lines [13/27] t5703: stop losing return codes of git commands [14/27] t7501: remove spaces after redirect operators [15/27] t7501: stop losing return codes of git commands [16/27] t7700: drop redirections to /dev/null [17/27] t7700: remove spaces after redirect operators [18/27] t7700: move keywords onto their own line [19/27] t7700: s/test -f/test_path_is_file/ [20/27] t7700: stop losing return codes of git commands [21/27] t: define test_grep_return_success() [22/27] t0090: mask failing grep status [23/27] t3600: mark git command as failing [24/27] t5004: ignore SIGPIPE in zipinfo [25/27] t5703: mask failing grep status [26/27] t9902: disable pipefail [27/27] t: run tests with `set -o pipefail` on Bash

Message ID

d27bc8bad35aaecaa1f73045f8247c9e5fe053aa.1573779465.git.liu.denton@gmail.com (mailing list archive)

State

New, archived

Headers

Date: Thu, 14 Nov 2019 17:00:53 -0800
From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 09/27] t4015: use test_write_lines()
Message-ID: 
 <d27bc8bad35aaecaa1f73045f8247c9e5fe053aa.1573779465.git.liu.denton@gmail.com>
References: <cover.1573779465.git.liu.denton@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1573779465.git.liu.denton@gmail.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

t: general test cleanup + `set -o pipefail` | expand

Commit Message

Denton Liu Nov. 15, 2019, 1 a.m. UTC

Instead of rolling our own method to write out some lines into a file,
use the existing test_write_lines().

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 t/t4015-diff-whitespace.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index 7fb83c8eff..4c540b1d70 100755
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
@@ -771,9 +771,9 @@  test_expect_success 'checkdiff detects new trailing blank lines (1)' '
 '
 
 test_expect_success 'checkdiff detects new trailing blank lines (2)' '
-	{ echo a; echo b; echo; echo; } >x &&
+	test_write_lines a b "" "" >x &&
 	git add x &&
-	{ echo a; echo; echo; echo; echo; } >x &&
+	test_write_lines a "" "" "" "" >x &&
 	test_must_fail git diff --check >check &&
 	grep "new blank line" check
 '

[09/27] t4015: use test_write_lines()

Commit Message

Patch