From patchwork Tue Jan 9 12:17:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 13514880 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93FF338DD6 for ; Tue, 9 Jan 2024 12:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="Y+QVXIdi"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="h6iYqq9G" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E8E8B5C03AF for ; Tue, 9 Jan 2024 07:17:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 09 Jan 2024 07:17:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1704802638; x=1704889038; bh=tZRbjzl0QV dGeYESEJ0Jfn4Oba5mNumZdzbFyilPiBg=; b=Y+QVXIdiBM5cigCMOfDOVYdDQZ Q7nfqGJ5o05az5cLhEeHJd+ai0z0/RaWoF9qMovywjgMaXnsKNEgziWo99alx2vC zwxI6Rzzf/sR28VvzPxbP3nmW2qzXe3A/2smMRVUunEQBUfhPlpmQa5d2q6JX2sc WXSx2wi1Klaf0G9Kaw/kSiiQ/8Kf2NRnhaTy+Lk9VyFLlvZnRKQsfq2zapyMXUub +Yp0nouLpVzn/azho1XNftYEUfmqG28JD4kyEe95YT8yygCS9IfHdmqb56CboECC DCoqb2OX4qGNVi/uRm5cidEZ3XuDOGI/Z8p4weMQ3KzY9oH1+m8PsIXAfP8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1704802638; x=1704889038; bh=tZRbjzl0QVdGeYESEJ0Jfn4Oba5m NumZdzbFyilPiBg=; b=h6iYqq9GjMVt6PXw5hqQNdyfONCa9z1r3LkEcVANted1 VMmk3nnfRa9JNXApVGnQCpnlUEOEIVOedn8LZcaHYXn9svuz6ignFpQh3pITGGpR OmQUvP8paKEs2CkPk4ukC+UN65m9YTNiIQPUQGMv9w0PzxjN+tGOJbiM1Tsa2gUL 28sraOlLawJhEXcYgSVh43+XES3TzN1aww1rsQ3D3ybkXa0/mrW3VlIHwZqW9Moj 5BX8biUA8A0yY/yOY9tVKD6qSoQK2/9UljKA6vGZGpn5nZgVrsMzs4T22oQ42aIg FF4cbK100iKl+WCr2zn/VUDgmapXZS1tmInKa3qcuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdehledgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre ertddtvdenucfhrhhomheprfgrthhrihgtkhcuufhtvghinhhhrghrughtuceophhssehp khhsrdhimheqnecuggftrfgrthhtvghrnhepheeghfdtfeeuffehkefgffduleffjedthf dvjeektdfhhedvlefgtefgvdettdfhnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 9 Jan 2024 07:17:18 -0500 (EST) Received: by vm-mail (OpenSMTPD) with ESMTPSA id b64e425c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 9 Jan 2024 12:14:40 +0000 (UTC) Date: Tue, 9 Jan 2024 13:17:16 +0100 From: Patrick Steinhardt To: git@vger.kernel.org Subject: [PATCH 4/6] t1419: mark test suite as files-backend specific Message-ID: References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: With 59c35fac54 (refs/packed-backend.c: implement jump lists to avoid excluded pattern(s), 2023-07-10) we have implemented logic to handle excluded refs more efficiently in the "packed" ref backend. This logic allows us to skip emitting refs completely which we know to not be of any interest to the caller, which can avoid quite some allocaitons and object lookups. This was wired up via a new `exclude_patterns` parameter passed to the backend's ref iterator. The backend only needs to handle them on a best effort basis though, and in fact we only handle it for the "packed-refs" file, but not for loose references. Consequentially, all callers must still filter emitted refs with those exclude patterns. The result is that handling exclude patterns is completely optional in the ref backend, and any future backends may or may not implement it. Let's thus mark the test for t1419 to depend on the REFFILES prereq. Signed-off-by: Patrick Steinhardt --- t/t1419-exclude-refs.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/t/t1419-exclude-refs.sh b/t/t1419-exclude-refs.sh index 5d8c86b657..1359574419 100755 --- a/t/t1419-exclude-refs.sh +++ b/t/t1419-exclude-refs.sh @@ -8,6 +8,12 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh +if test_have_prereq !REFFILES +then + skip_all='skipping `git for-each-ref --exclude` tests; need files backend' + test_done +fi + for_each_ref__exclude () { GIT_TRACE2_PERF=1 test-tool ref-store main \ for-each-ref--exclude "$@" >actual.raw