diff mbox series

packfile: make `close_pack_revindex()` static

Message ID dad2b73c84f1c1575a6bce04a449ee1236680b10.1638658219.git.me@ttaylorr.com (mailing list archive)
State Accepted
Commit 79aee56c1ee342953a6d9f49f45b89d7f44a624f
Headers show
Series packfile: make `close_pack_revindex()` static | expand

Commit Message

Taylor Blau Dec. 4, 2021, 10:51 p.m. UTC 
Since its definition in 2f4ba2a867 (packfile: prepare for the existence
of '*.rev' files, 2021-01-25), the only caller of
`close_pack_revindex()` was within packfile.c.

Thus there is no need for this to be exposed via packfile.h, and instead
can remain static within packfile.c's compilation unit. While we're
here, move the function's opening brace onto its own line.

Noticed-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
Noticed by Ramsay in a separate thread[1], because the two
style/organization fixes here were propagated into the new cruft pack
code.

[1]: https://lore.kernel.org/git/ec008905-5e04-944d-f164-d52a622f0531@ramsayjones.plus.com/

 packfile.c | 3 ++-
 packfile.h | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.34.1.25.gb3157a20e6
diff mbox series

Patch

diff --git a/packfile.c b/packfile.c
index 6423d77faa..c38e749eb5 100644
--- a/packfile.c
+++ b/packfile.c
@@ -324,7 +324,8 @@  void close_pack_index(struct packed_git *p)
 	}
 }

-void close_pack_revindex(struct packed_git *p) {
+static void close_pack_revindex(struct packed_git *p)
+{
 	if (!p->revindex_map)
 		return;

diff --git a/packfile.h b/packfile.h
index 186146779d..a3f6723857 100644
--- a/packfile.h
+++ b/packfile.h
@@ -90,7 +90,6 @@  uint32_t get_pack_fanout(struct packed_git *p, uint32_t value);

 unsigned char *use_pack(struct packed_git *, struct pack_window **, off_t, unsigned long *);
 void close_pack_windows(struct packed_git *);
-void close_pack_revindex(struct packed_git *);
 void close_pack(struct packed_git *);
 void close_object_store(struct raw_object_store *o);
 void unuse_pack(struct pack_window **);