diff mbox series

[v4,17/17] sparse-checkout: cone mode should not interact with .gitignore

Message ID ed1f148763437925248684b37a0c8b70f837d40b.1571147765.git.gitgitgadget@gmail.com
State New, archived
Headers show
Series New sparse-checkout builtin and "cone" mode | expand

Commit Message

Philippe Blain via GitGitGadget Oct. 15, 2019, 1:56 p.m. UTC
From: Derrick Stolee <dstolee@microsoft.com>

During the development of the sparse-checkout "cone mode" feature,
an incorrect placement of the initializer for "use_cone_patterns = 1"
caused warnings to show up when a .gitignore file was present with
non-cone-mode patterns. This was fixed in the original commit
introducing the cone mode, but now we should add a test to avoid
hitting this problem again in the future.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
 t/t1091-sparse-checkout-builtin.sh | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox series


diff --git a/t/t1091-sparse-checkout-builtin.sh b/t/t1091-sparse-checkout-builtin.sh
index 48493e1012..14141b8f54 100755
--- a/t/t1091-sparse-checkout-builtin.sh
+++ b/t/t1091-sparse-checkout-builtin.sh
@@ -269,4 +269,11 @@  test_expect_success 'fail when lock is taken' '
 	test_i18ngrep "File exists" err
+test_expect_success '.gitignore should not warn about cone mode' '
+	git -C repo config --worktree core.sparseCheckoutCone true &&
+	echo "**/bin/*" >repo/.gitignore &&
+	git -C repo reset --hard 2>err &&
+	test_i18ngrep ! "disabling cone patterns" err