From patchwork Tue May 7 04:53:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 13656233 Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2809E6A8A7 for ; Tue, 7 May 2024 04:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715057626; cv=none; b=ZhTGtJ9WsZ2geXGluC7jqyygSLv66FMUurVurwhu5PY7SN8PR95mqEwOaL1DEfU3PQEroXaQIaUl4cbTAQGXxjSD0b38x7hNE9woXaZ7Onsj64RCgYjvq20uYHymN0cAf5AVp+hynjtffABw8jcbmRaI4kiYTgq3UwgS6TlNJ5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715057626; c=relaxed/simple; bh=SFkonS1Deut8+sOzXo3R7d2TU6wio+VaWoiIFo7PSig=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e4estba4R4GyKMnXhgz5vK0HW3xM6IzNrzDjwG640BDj5+Je2iI4NVnVACH78Ye93Davfo4HgWnt8hhSFuHDfwxW0kQcGRiMw0xLjnSyfVzSLoMovGHZOUNnPGA+6EgAF9mWF7I8WSMJbPJasPDkloHmqosm6GccMjb9sH72XHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=sf38DCAv; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=gLn16HZF; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="sf38DCAv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="gLn16HZF" Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 3763D138024A; Tue, 7 May 2024 00:53:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 07 May 2024 00:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1715057624; x=1715144024; bh=C2kQmGl05J jE+HaDHK30rr/Q7Q7WFj1mzvzVKnUZ6CY=; b=sf38DCAvlR7ZCiM3jG3F5rjO4J XPiYtmo7Z+xZLz83+xBzh+YFLiwqqME4B1bX0HK9AvENsvtbFPy6+NYaiblczGxo JDGPmPyYmQz3QN/W3N2LBQw/TOIsznm6a4RNMF50c6fPyeXfrLWwqVCsUurkGMUf LvzT/y+AU0tXBY4y0kY0VJ9syzaXSwfXV28BhRdY8O25mO+Hoxs7bulryTFzS57e Qtv2vtT96rzEm+10q5FRdrmUQom2+x3fdQBfLUySVmITsOzkIzDavACgJ3vojPtJ u4DX0UF0Aiq7s/FN+gUTJST9RsGgYlF2Np8vqOS7H6YfdlqZ4T27oZ+BjqWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715057624; x=1715144024; bh=C2kQmGl05JjE+HaDHK30rr/Q7Q7W Fj1mzvzVKnUZ6CY=; b=gLn16HZF4A/JMPu9q02WrxogDDhgIidgOwkN7A9x6gn+ j3B1YuOcfA7RjSf3OGHCJoYXRwhkO3A/SlYzEspWnuftby6UK3ujYXhs/uRXsUKY 6pQgPsjIs5g1NvBAfm52NCDinleKXsVBTB/L/TI0dFpF0S6w2PwpIz3Z7gKDFsWB YAObhBQkh3rXdLfNhVnX+iiRVNOMiYhzRmEwwF3l4/wOAq7ElNcLYlSFZSr84LCJ 5VQb8q8HwfZx+RIlm1T1Ohm2IiRXr5361Mw4Zi2zmg6C7hmc42ICR6DDXePngAL9 4dd5bwqXsE/Bf6HZFxGpU+K75+DW7JaGb3zC/bTlJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvjedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepueektdevtdffveeljeetgfehheeigeekleduvdeffeeghefgledttdehjeelffet necuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepphhsse hpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 May 2024 00:53:42 -0400 (EDT) Received: by localhost (OpenSMTPD) with ESMTPSA id 827b26cb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 7 May 2024 04:53:35 +0000 (UTC) Date: Tue, 7 May 2024 06:53:40 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Junio C Hamano , "brian m. carlson" , Justin Tobler Subject: [PATCH v4 12/13] oss-fuzz/commit-graph: set up hash algorithm Message-ID: References: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Our fuzzing setups don't work in a proper repository, but only use the in-memory configured `the_repository`. Consequently, we never go through the full repository setup procedures and thus do not set up the hash algo used by the repository. The commit-graph fuzzer does rely on a properly initialized hash algo though. Initialize it explicitly. Signed-off-by: Patrick Steinhardt --- oss-fuzz/fuzz-commit-graph.c | 1 + 1 file changed, 1 insertion(+) diff --git a/oss-fuzz/fuzz-commit-graph.c b/oss-fuzz/fuzz-commit-graph.c index fe15e2c225..75e668a057 100644 --- a/oss-fuzz/fuzz-commit-graph.c +++ b/oss-fuzz/fuzz-commit-graph.c @@ -18,8 +18,9 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) * normally be read from the repository's gitdir. We want to avoid * touching the disk to keep the individual fuzz-test cases as fast as * possible. */ + repo_set_hash_algo(the_repository, GIT_HASH_SHA1); the_repository->settings.commit_graph_generation_version = 2; the_repository->settings.commit_graph_read_changed_paths = 1; g = parse_commit_graph(&the_repository->settings, (void *)data, size); repo_clear(the_repository);